-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix audio codec not being used in UniversalAudio #9192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like it works when cherry-picked off v10.8.9
However, you do have to specify the actual ffmpeg encoder (in this case, I had to do UniversalAudio seems broken on master, but master is supposed to be unstable after all 🙃
|
cvium
approved these changes
Feb 2, 2023
Shadowghost
approved these changes
Feb 2, 2023
Bond-009
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR specifies the audio codec when creating the ffmpeg command line when streaming audio. Currently, Jellyfin doesn't specify this and therefore just falls back on whatever the default codec of the container is. For example, here is an ffmpeg log run from a call to
/Audio/{id}/universal?transcodingContainer=ogg&audioCodec=opus
. Note how Vorbis is used despite audioCodec being set to opus.I haven't tested this PR yet since its 4am and I don't want to fight macOS right now, but I'll give it a go tomorrow.