Fix cachedir missing from Docker container #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the /cache volume and set it to writeable by all. This allows for those using jellyfin to continue using it without modifying their config. However, retaining cache will require one to mount the /cache volume. Also make the /config and /media dirs 777 by default. No permissions on mounted volumes will be changed.
cvium
reviewed
Feb 16, 2019
| && rm -rf /var/lib/{apt,dpkg,cache,log} | ||
| && rm -rf /var/lib/{apt,dpkg,cache,log} \ | ||
| && mkdir -p /cache /config /media \ | ||
| && chmod 777 /cache /config /media |
There was a problem hiding this comment.
No, the user creating these folders is always root. The user running jellyfin can change depending on how one runs the container.
There was a problem hiding this comment.
We can't chown at this point since we don't know the user. We can't chown after they've been mounted since that would carry over to the host volume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the /cache volume and set it to writeable by all. This allows for
those using jellyfin to continue using it without modifying their
config. However, retaining cache will require one to mount the /cache
volume.
Also make the /config and /media dirs 777 by default. No permissions on
mounted volumes will be changed.