Fix nvenc preset order #9538
Merged
Fix nvenc preset order #9538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
approved these changes
Mar 25, 2023
|
@TheTyrius Can you rebase to the release-10.8.z branch? |
Will do. Should I generally target release branches (for future PRs)? I skimmed the contribution docs, and they told me to target master :) |
Bug fixes -> Release branches (we will backport it to the master branch later) |
TheTyrius
force-pushed
the
fix-nvenc-preset-order
branch
from
13a686f
to
6f29d04
Compare
TheTyrius
force-pushed
the
fix-nvenc-preset-order
branch
from
6f29d04
to
bf37db7
Compare
|
Looks fine now (and learnt about |
Shadowghost
approved these changes
Mar 25, 2023
nyanmisaka
approved these changes
Mar 25, 2023
1 task
nyanmisaka
added a commit
to nyanmisaka/jellyfin
that referenced
this pull request
Apr 14, 2023
jellyfin-bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
Fix nvenc preset order Original-merge: 79bb756 Merged-by: Cody Robibero <cody@robibe.ro> Backported-by: Bond_009 <bond.009@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changed the ordering of the "slow" and "slower" presets in the transcoding helper, so they are aligned with the order in the settings dropdown.
Did the same to a switch-case where there is no change in behavior right now (but might prevent a bug like this in the future).
Issues
First raised in #9537 thanks nyanmisaka for giving it a look so incredibly quickly (and also for all the other work you do on Jellyfin)