-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert string MediaType to enum MediaType #9762
Conversation
Changes in OpenAPI specification found. Expand to see details.What's Changed
|
/// <summary> | ||
/// Unknown media type. | ||
/// </summary> | ||
Unknown = 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to get unknown media types via the API or do unknown media items only exist internally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could probably go through and remove Unknown and have the default be null instead, but we get warnings if the default doesn't exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably sane to have a good default value where everyone knows to just error out because something is wrong, right?
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Requested by client devs
Works as normal from my testing