Reduce bottlenecks scan code #9863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Bond-009
commented
Jun 6, 2023
•
Bond-009
commented
- Removes MetadataThrottler, we already limit the amount of directories to start scanning (this PR multiplies this limit by 2) in and the number of ffprobe instances, this extra throttling doesn't seem necessary.
- Increases the amount of thumbnail extraction processes from 2 to 2 * the number of threads
crobibero
approved these changes
Jun 10, 2023
Shadowghost
approved these changes
Jun 10, 2023
goremykin
reviewed
Aug 26, 2023
| @@ -809,27 +808,12 @@ private bool IsSaverEnabledForItem(IMetadataSaver saver, BaseItem item, LibraryO | |||
| { | |||
| var results = await provider.GetSearchResults(searchInfo, cancellationToken).ConfigureAwait(false); | |||
|
|
|||
| var list = results.ToList(); | |||
There was a problem hiding this comment.
Multiple enumeration was introduced here and as a result potential bugs.
As I see, most of GetSearchResults implementations return arrays and there is no problem in this case.
But at least MusicBrainzArtistProvider returns a lazy enumeration using yield statement. And here we have a bug:
MusicBrainzArtistProvider lazily creates RemoteSearchResult while we iterate here to set item.SearchProviderName and then it creates new ones when we iterate this enumerable again outside. So we actually lose SearchProviderName
But I haven't tested yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.