Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

/tokens/:tokenId/send sending other Token with auto waitForConfirmation #135

Closed
fuxingloh opened this issue Aug 6, 2021 · 3 comments · Fixed by #148
Closed

/tokens/:tokenId/send sending other Token with auto waitForConfirmation #135

fuxingloh opened this issue Aug 6, 2021 · 3 comments · Fixed by #148
Labels
area/module-api kind/feature New feature request needs/triage Waiting for triage to be accepted

Comments

@fuxingloh
Copy link
Contributor

What would you like to be added:

https://github.com/DeFiCh/playground/blob/c9c0128ad2dee61e359d1442b976680a39689eb7/src/module.api/wallet.controller.ts#L51-L52

Currently, only tokenId=0 is supported due to the complexity of sending DFI Token as RPC block this type of transaction.

Why is this needed:

To remove waiting on cypress tests, to allow a more nature testing paradigm.

@fuxingloh fuxingloh added kind/feature New feature request area/module-api labels Aug 6, 2021
@defichain-bot
Copy link
Contributor

@fuxingloh: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@defichain-bot defichain-bot added the needs/triage Waiting for triage to be accepted label Aug 6, 2021
@fuxingloh
Copy link
Contributor Author

Might help on improvement. API fails often on Cypress - https://dashboard.cypress.io/projects/oqk3fk/runs/1430/test-results/cf6ffcea-a334-45c1-8d33-09e4fa9e7a35?statuses=%5B%7B%22value%22%3A%22FAILED%22%2C%22label%22%3A%22FAILED%22%7D%5D

I will prioritize this, the flakiness is pretty annoying.

@fuxingloh fuxingloh changed the title /tokens/:tokenId/sendtoaddress sending other Token with auto waitForConfirmation /tokens/:tokenId/send sending other Token with auto waitForConfirmation Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/module-api kind/feature New feature request needs/triage Waiting for triage to be accepted
Projects
None yet
3 participants