- Added check for maximumlength of account.

- Added test with random string.
jellyhive · Oct 13, 2023 · 0d0186c · 0d0186c
1 parent 31a5a17
commit 0d0186c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 9 deletions.
diff --git a/src/SwedishBankAccounts.UnitTests/BankAccountNumberTests.cs b/src/SwedishBankAccounts.UnitTests/BankAccountNumberTests.cs
@@ -4,7 +4,7 @@ namespace SwedishBankAccounts.UnitTests;
 
 public class BankAccountNumberTests : UnitTests
 {
-    [Theory] 
+	[Theory] 
     [InlineData("9071, 417 23 83", "Multitude Bank")]
     [InlineData("6683764450808", "Handelsbanken")]
     [InlineData("8424-4,983 189 224-6", "Swedbank")]
@@ -47,12 +47,20 @@ public class BankAccountNumberTests : UnitTests
     [InlineData("9892 398 7468", "Riksgälden")]
     [InlineData("9578 633 1128", "Sparbanken Syd")]
     [InlineData("9340 321 4681", "Swedbank")]
-    public void AccountNumber_TryParse_ShouldValidate(string accountNumber, string bankName)
+	public void AccountNumber_TryParse_ShouldValidate(string accountNumber, string bankName)
     {
         BankAccountNumber.TryParse(accountNumber, out var bankAccountNumber)
             .Should().BeTrue($"it should be validated to {bankName}");
 
         bankAccountNumber.Should().NotBeNull($"it should be validated to {bankName}");
         bankAccountNumber!.Bank.Should().Be(bankName, $"it should be validated to {bankName}");
     }
+
+    [Fact]
+    public void AccountNumner_TryParse_ShouldReturnFalse()
+    {
+	    BankAccountNumber.TryParse(Fixture.Create<string>(), out var bankAccountNumber).Should().BeFalse();
+
+        bankAccountNumber.Should().BeNull();
+    }
 }
diff --git a/src/SwedishBankAccounts/BankAccountNumber.cs b/src/SwedishBankAccounts/BankAccountNumber.cs
@@ -24,7 +24,12 @@ public record BankAccountNumber
     /// </summary>
     public string AccountNumber { get; }
 
-    private BankAccountNumber(string bank, string sortingCode, string accountNumber)
+    /// <summary>
+    /// Maxlength of Bank Account Number
+    /// </summary>
+    private const int AccountMaxLength = 16;
+
+	private BankAccountNumber(string bank, string sortingCode, string accountNumber)
     {
         Bank = bank;
         SortingCode = sortingCode;
@@ -81,7 +86,7 @@ public static bool TryParse(string value, InitOptions? initOptions, out BankAcco
         bankAccountNumber = null;
         value = Regex.Replace(value, @"[^\d]", "");
 
-        if (value.Length > MaxAccountLength) return false;
+        if (value.Length > AccountMaxLength) return false;
         if (value.StartsWith("8") && value.Length < 7) return false;
         if (!value.StartsWith("8") && value.Length < 6) return false;
 
@@ -104,9 +109,4 @@ public static bool TryParse(string value, InitOptions? initOptions, out BankAcco
         bankAccountNumber = new BankAccountNumber(bank.Name, sortingCode, accountNumber);
         return true;
     }
-
-    /// <summary>
-    /// Maxlength of Bank Account Number
-    /// </summary>
-    private const int MaxAccountLength = 16;
 }