Close all files.

[garyvdm]

Python 3.4 add as new feature that emits a warning if a file object gets deleted or garbage collected before it is closed.

Running the test suite under 3.4, I was getting a lot of these warnings. This patch fixes all of these warnings.

In addition, it also fixes a bunch of errors I was getting when running the test suite under wine, similar to:

======================================================================
ERROR: test_simple (dulwich.tests.test_porcelain.PullTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Python27\lib\shutil.py", line 250, in rmtree
    onerror(os.remove, fullname, sys.exc_info())
  File "C:\Python27\lib\shutil.py", line 248, in rmtree
    os.remove(fullname)
WindowsError: [Error 32] Sharing violation: 'c:\\users\\garyvdm\\temp\\tmpabr7v1\\tmpa3bguj'

[garyvdm]

Got merge conflicts. Rebased version on the way.

[jelmer]

Can you split this up?I agree that this the correct thing to do for proto.

For repositories I am less certain. We should definitely do something, but another approach would be to use a "read locks"-style approach like in bzrlib. That would have the added benefit of not having to stat so much when looking for objects, to see if loose object files are present or if the pack file directory has changed.

[garyvdm]

On Wed, Jun 4, 2014 at 2:44 AM, Jelmer Vernooij notifications@github.com
wrote:

Can you split this up?I agree that this the correct thing to do for proto.

Sure, will do.

[garyvdm]

I've removed the repo changes, which I will return to later, and I have split up the changes in to different commits. (Doing this was valuable as I picked up a number of mistakes during this process.)

As most of the lines that have changed in this patch are just a change in indentation, I find using meld with it's synchronization feature very helpful to review the diff. e.g:
http://picpaste.com/Screenshot_from_2014-06-04_14_11_16.png