Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoding ARCHFLAGS breaks the build against fink's python #24

Merged
merged 1 commit into from
May 17, 2011
Merged

Hardcoding ARCHFLAGS breaks the build against fink's python #24

merged 1 commit into from
May 17, 2011

Conversation

bcully
Copy link
Contributor

@bcully bcully commented May 15, 2011

Fink's python is either i386 or amd64, but not universal. Setting ARCHFLAGS to the
empty string produces a successful build against both OS X python and fink python.
The modules will no longer be universal -- if that is an issue, we can change the
test to extract ARCHFLAGS from distutils.sysconfig and remove ppc if necessary.

Fink's python is either i386 or amd64, but not universal. Setting ARCHFLAGS to the
empty string produces a successful build against both OS X python and fink python.
The modules will no longer be universal -- if that is an issue, we can change the
test to extract ARCHFLAGS from distutils.sysconfig and remove ppc if necessary.
@jelmer
Copy link
Owner

jelmer commented May 16, 2011

I've asked for feedback about this on the dulwich list.

@daenney
Copy link

daenney commented May 16, 2011

I just tried that patch, it works on 10.6 with XCode 4.0.1 so I'm pretty sure we can say that the change should be fine.

switch:dulwich daenney$ sudo /usr/bin/python2.6 setup.py build
    running build
    running build_py
    creating build
    creating build/lib.macosx-10.6-universal-2.6
    creating build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/__init__.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/_compat.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/client.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/diff_tree.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/errors.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/fastexport.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/file.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/index.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/log_utils.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/lru_cache.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/object_store.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/objects.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/pack.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/patch.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/protocol.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/repo.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/server.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    copying dulwich/web.py -> build/lib.macosx-10.6-universal-2.6/dulwich
    creating build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/__init__.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_blackbox.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_client.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_diff_tree.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_fastexport.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_file.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_index.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_lru_cache.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_object_store.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_objects.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_pack.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_patch.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_protocol.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_repository.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_server.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/test_web.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    copying dulwich/tests/utils.py -> build/lib.macosx-10.6-universal-2.6/dulwich/tests
    running build_ext
    building 'dulwich._objects' extension
    creating build/temp.macosx-10.6-universal-2.6
    creating build/temp.macosx-10.6-universal-2.6/dulwich
    gcc-4.2 -fno-strict-aliasing -fno-common -dynamic -DNDEBUG -g -fwrapv -Os -Wall -Wstrict-prototypes -DENABLE_DTRACE -pipe -I/System/Library/Frameworks/Python.framework/Versions/2.6/include/python2.6 -c d
    gcc-4.2 -Wl,-F. -bundle -undefined dynamic_lookup build/temp.macosx-10.6-universal-2.6/dulwich/_objects.o -o build/lib.macosx-10.6-universal-2.6/dulwich/_objects.so
    building 'dulwich._pack' extension
    gcc-4.2 -fno-strict-aliasing -fno-common -dynamic -DNDEBUG -g -fwrapv -Os -Wall -Wstrict-prototypes -DENABLE_DTRACE -pipe -I/System/Library/Frameworks/Python.framework/Versions/2.6/include/python2.6 -c d
    gcc-4.2 -Wl,-F. -bundle -undefined dynamic_lookup build/temp.macosx-10.6-universal-2.6/dulwich/_pack.o -o build/lib.macosx-10.6-universal-2.6/dulwich/_pack.so
    building 'dulwich._diff_tree' extension
    gcc-4.2 -fno-strict-aliasing -fno-common -dynamic -DNDEBUG -g -fwrapv -Os -Wall -Wstrict-prototypes -DENABLE_DTRACE -pipe -I/System/Library/Frameworks/Python.framework/Versions/2.6/include/python2.6 -c d
    gcc-4.2 -Wl,-F. -bundle -undefined dynamic_lookup build/temp.macosx-10.6-universal-2.6/dulwich/_diff_tree.o -o build/lib.macosx-10.6-universal-2.6/dulwich/_diff_tree.so
    running build_scripts
    creating build/scripts-2.6
    copying and adjusting bin/dulwich -> build/scripts-2.6
    copying and adjusting bin/dul-daemon -> build/scripts-2.6
    copying and adjusting bin/dul-web -> build/scripts-2.6
    changing mode of build/scripts-2.6/dulwich from 644 to 755
    changing mode of build/scripts-2.6/dul-daemon from 644 to 755
    changing mode of build/scripts-2.6/dul-web from 644 to 755

@jelmer jelmer merged commit b9fa7e3 into jelmer:master May 17, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants