Versioneer #489
Closed
Versioneer #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.16.3. # gpg: Signature made Sat, Jan 14, 2017 12:02:08 PM PST # gpg: using RSA key 9A2D24A504D1E9F8 # gpg: Can't check signature: public key not found
- if tag is not annotated, then it will be a commit object, instead of creating a tag object - don't check if ref object is tag, instead check if "tags" is in the ref name - change docstring to show how release_robot could be used as alternate to versioneer, ie: copy and paste gist https://gist.github.com/mikofski/e923750b415e4e4961b65a8eb42999e8#file-xyz__init__-py - don't use contrib folder as default projdir, instead default to '.' - return tag meta data if there is any from get_recent_tags() as tuple (tag time, tag id, tag name) otherwise it's (None, None, None) - remove test_tag_pattern from release_robot since it's in test_release_robot() - add test of current 95 dulwich tags to test_release_robot Signed-off-by: Mark Mikofski <mark.mikofski@sunpowercorp.com>
|
Thanks for the patch. One of the tests seems to be timezone-specific: ======================================================================
|
|
Ah, I see what's happening. Please construct a test repository and run tests against that, rather than using the dulwich repository itself. This is problematic because it means local changes cause the tests to fail, and also because anybody who is running dulwich from e.g. a tarball won't be able to run the test. |
* does this fix the assert failures for commit times? * setup class to clone github dulwich repo * teardown class to close repo and remove repo dir * move constants for tag test to class * separate tag test into its own test class * set tag meta to None for unannotated tags, instead of (None, None, None) * change test and test data wrt to unannotated tags * clarify get_recent_tags() docstring Signed-off-by: Mark Mikofski <mark.mikofski@sunpowercorp.com>
* use zipped test repo instead of github repo * add some logging * put each test repo in temp dir, no race conditions on travis? Signed-off-by: Mark Mikofski <mark.mikofski@sunpowercorp.com>
Signed-off-by: Mark Mikofski <mark.mikofski@sunpowercorp.com>
|
it's passing both Python versions for me now: Python-2Python-3feel free to squash commits. it's a mess. I had to use zip file and a tempdir |
|
On Wed, Jan 18, 2017 at 12:04:52AM -0800, Mark Mikofski wrote:
it's passing both Python versions for me now, last commit hasn't trigger travis yet:
# Python-2
$ py -2 -m nose dulwich/contrib/test_release_robot.py -v --nologcapture
test get recent tags ... ok
test tag patterns ... ok
----------------------------------------------------------------------
Ran 2 tests in 0.118s
OK
# Python-3
$ py -3 -m nose dulwich/contrib/test_release_robot.py -v --nologcapture
test get recent tags ... ok
test tag patterns ... ok
----------------------------------------------------------------------
Ran 2 tests in 0.131s
OK
feel free to squash commits. it's a mess. I had to use zip file and a tempdir
Please construct a Repo inside of the test like the other tests. Debugging
tests that rely on zip files is harder, and inconsistent with the rest of
Dulwich.
See e.g. dulwich/tests/test_server.py:1070 for an example of how to do this.
|
|
workin' on it |
|
ok, I think it's ready now |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in release robot that doesn't detect unannotated tags. IE if tag created with out the
-aoption.Also add test of
get_recent_tagsthat compares 95 tags from beginning of dulwich repo.Also change docstring to give example similar to this gist of how to emulate versioneer.