Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple client configuration instructions #63

Merged
merged 1 commit into from Aug 22, 2017
Merged

Add simple client configuration instructions #63

merged 1 commit into from Aug 22, 2017

Conversation

ecksun
Copy link
Contributor

@ecksun ecksun commented Aug 16, 2017

Super simple addition based on an explanation given by jelmer on IRC

@codecov
Copy link

codecov bot commented Aug 16, 2017

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   72.65%   72.65%           
=======================================
  Files          23       23           
  Lines        3174     3174           
  Branches      382      382           
=======================================
  Hits         2306     2306           
  Misses        779      779           
  Partials       89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed0bb5...51f4d65. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 16, 2017 •
edited

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   72.65%   72.65%           
=======================================
  Files          23       23           
  Lines        3174     3174           
  Branches      382      382           
=======================================
  Hits         2306     2306           
  Misses        779      779           
  Partials       89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed0bb5...09f5ee6. Read the comment docs.

@jelmer
Copy link
Owner

jelmer commented Aug 22, 2017

Thanks!

jelmer
jelmer approved these changes Aug 22, 2017
View reviewed changes
Copy link
Owner

@jelmer jelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. I suspect we'll probably want to move this to docs/clients.rst at some point, but we can do that later.

README.rst

Clients that lack such automated discovery require the direct URL to a calendar
or addressbook. One such client is Thunderbird lightning in which case you
should provide a URL similar to the following:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I was worried this was a Xandikos bug rather than a missing feature in Thunderbird/Lightning, but this page confirms it: http://sabre.io/dav/clients/thunderbird/

@jelmer jelmer merged commit 09f5ee6 into jelmer:master Aug 22, 2017
@ecksun ecksun deleted the client_instructions branch August 30, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelmer jelmer jelmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ecksun @jelmer