-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All asset bundles also in base_assets when using Unity 2021 #62
Comments
Yes, there is an issue with 2021 and addressables 1.19+, as in the combination of those, Addressables no longer copies bundles to StreamingAssets. Not sure how to fix it yet, but I got some time off in 2 weeks, at which point I'll be taking a look at this. |
Thanks you for the update. I mean, they work fine, they build correctly, upload correctly and can be loaded/addressed without any issue. The problem is "just" that the base/base_assets bundle also contains all the asset bundles. If you take a look at the delivery section in play console you will see that the base_assets bundle is the size of base.bundle and all other asset bundles. While building, I saw that at one point in the process the com.unity.addressables/assets/android folder is cleaned while building the player with Unity 2020, but it is not cleaned when building with 2021, maybe thats the reason? (even once the build is done all bundles are still in this folder) Anyway, thanks for taking a look at this, let me know if you need someone to debug and test early, I will be around! Addressables 1.19.19 Our usual build procedure: ... buildResult = Khepri.PlayAssetDelivery.Editor.AssetPackBuilder.BuildBundleWithAssetPacks(buildPlayerOptions, EditorUserBuildSettings.androidBuildSubtarget); |
Did you have any chance looking at this issue already? Any way I can be of help here? |
Investigated this issue a bit and it looks like we can get back to normal AAB size by manually removing the duplicate bundles from the base bundle when building (very hacky, but at least working for now with Unity 2021.3.11f1, addressables 1.19.19 and app bundle 1.7.0)
|
Sorry, I've been extremely busy with work lately and had little time. I had a quick look, but I haven't had time to verify the fix. so I thought it is as simple as changing: PlayAssetPackBundlesPreprocessor.cs line 22 to use the BuildPath instead of PlayerBuildDataPath
But Unity changed how android is being build, and adds things to a manifest list, which isn't accessable, so I need to hack around that..., thank you Unity... |
Ok think I resolved it, a less hacky way then what you suggested. Basically by removing the bundle slightly earlier in the process than in Unity 2020. I've created a new release 1.0.1. |
Less hacky is always preferred :) Will try your changes... |
Unfortunately your fix didn't solve the issue, actually got worse
|
same for me :( |
(cherry picked from commit d5d05f4)
We make use of this plugin for quite a while now which always worked flawlessly since Unity 2019. But after upgrading to Unity 2021.3.5f1 the final AAB is almost double size, after investigating it looks like all assets bundles are also part of base_asset (base_assets/assets/aa has all asset bundles too, which was not the case in earlier versions).
Is this maybe a known issue already? Does anyone have a hint where to look at? (maybe Unity 2021 is building the addressables again when building the player?)
We are using Addressables 1.19.19 and play-asset-delivery 1.7.0 (worked fine with Unity 2020)
The text was updated successfully, but these errors were encountered: