Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plat 602 keycloak integration #1183

Merged
merged 21 commits into from
Mar 31, 2023
Merged

Conversation

nour-borgi
Copy link
Contributor

In this PR:

  • Add keycloak startegy (using passport-openidconnect)

@nour-borgi nour-borgi changed the base branch from master to PLAT-638-adjust-login-cookies-test-fix February 16, 2023 15:22
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1183 (c6ff04b) into master (1a3e390) will increase coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head c6ff04b differs from pull request most recent head fa2893c. Consider uploading reports for the commit fa2893c to get more accurate results

@@            Coverage Diff             @@
##           master    #1183      +/-   ##
==========================================
+ Coverage   86.23%   86.44%   +0.21%     
==========================================
  Files          84       85       +1     
  Lines        5716     5800      +84     
==========================================
+ Hits         4929     5014      +85     
+ Misses        787      786       -1     
Impacted Files Coverage Δ
src/model/passport.js 100.00% <ø> (ø)
src/protocols/index.js 100.00% <ø> (ø)
src/server.js 73.17% <ø> (ø)
src/api/authentication.js 95.87% <100.00%> (+0.27%) ⬆️
src/api/users.js 93.36% <100.00%> (+0.81%) ⬆️
src/koaApi.js 100.00% <100.00%> (ø)
src/middleware/sessionStore.js 95.00% <100.00%> (+1.25%) ⬆️
src/model/users.js 100.00% <100.00%> (ø)
src/passport.js 96.72% <100.00%> (+0.72%) ⬆️
src/protocols/openid.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/model/users.js Outdated Show resolved Hide resolved
Copy link
Member

@rcrichton rcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. Could you merge the base branch in so I can test it out with the latest changes.

config/default.json Show resolved Hide resolved
config/default.json Outdated Show resolved Hide resolved
@nour-borgi nour-borgi changed the base branch from PLAT-638-adjust-login-cookies-test-fix to master March 27, 2023 13:37
rcrichton
rcrichton previously approved these changes Mar 31, 2023
Copy link
Member

@rcrichton rcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one small comment.

config/config.md Outdated Show resolved Hide resolved
Copy link
Member

@rcrichton rcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nour-borgi nour-borgi merged commit 81c6286 into master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants