Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Pending Async as status for transaction #1207

Merged
merged 18 commits into from
Oct 13, 2023
Merged

Conversation

brett-onions
Copy link
Contributor

Updating backend to allow transaction status of "Pending Async" TB-162

src/model/channels.js Outdated Show resolved Hide resolved
@bradsawadye
Copy link
Contributor

@brett-onions looks good. Please add some tests

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6f53407) 86.95% compared to head (b811f6c) 87.00%.

❗ Current head b811f6c differs from pull request most recent head d13259b. Consider uploading reports for the commit d13259b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1207      +/-   ##
==========================================
+ Coverage   86.95%   87.00%   +0.05%     
==========================================
  Files          89       89              
  Lines        5994     6002       +8     
==========================================
+ Hits         5212     5222      +10     
+ Misses        782      780       -2     
Files Coverage Δ
src/api/apps.js 95.45% <100.00%> (ø)
src/api/clients.js 85.43% <100.00%> (+3.25%) ⬆️
src/middleware/messageStore.js 93.18% <100.00%> (-0.47%) ⬇️
src/middleware/router.js 91.87% <ø> (ø)
src/middleware/sessionStore.js 94.73% <100.00%> (ø)
src/model/channels.js 100.00% <ø> (ø)
src/server.js 73.27% <100.00%> (ø)
src/api/tasks.js 82.63% <66.66%> (ø)
src/model/transactions.js 96.15% <80.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brett-onions brett-onions marked this pull request as ready for review September 21, 2023 14:50
Copy link

@Lumiere-Lodi Lumiere-Lodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now with the tests.

src/middleware/messageStore.js Outdated Show resolved Hide resolved
arran-standish
arran-standish previously approved these changes Sep 28, 2023
Copy link
Collaborator

@arran-standish arran-standish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

nour-borgi

This comment was marked as outdated.

nour-borgi
nour-borgi previously approved these changes Sep 28, 2023
Copy link
Contributor

@nour-borgi nour-borgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatthewErispe
Copy link
Collaborator

this is pending bug fix https://jembiprojects.jira.com/browse/TB-202

MatthewErispe
MatthewErispe previously approved these changes Oct 5, 2023
Copy link
Collaborator

@MatthewErispe MatthewErispe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brett-onions happy with the bug fix change

@MatthewErispe MatthewErispe merged commit 69e71eb into master Oct 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants