-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Pending Async as status for transaction #1207
Conversation
@brett-onions looks good. Please add some tests |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1207 +/- ##
==========================================
+ Coverage 86.95% 87.00% +0.05%
==========================================
Files 89 89
Lines 5994 6002 +8
==========================================
+ Hits 5212 5222 +10
+ Misses 782 780 -2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now with the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
07b84a5
this is pending bug fix https://jembiprojects.jira.com/browse/TB-202 |
…HIM-Response-Header adding empty header obj to pass condition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brett-onions happy with the bug fix change
…rerun-bug-fix Tb 202 investigate open him core rerun bug fix
Updating backend to allow transaction status of "Pending Async" TB-162