Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tb 181 make endpoints unique by pattern and method #210

Merged

Conversation

bradsawadye
Copy link
Contributor

The endpoint is now unique by a combination of the endpoint's pattern and the http method. This allows us to have multiple endpoints with the same url but different http methods

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3847a4) 96.75% compared to head (cc929bc) 96.75%.
Report is 3 commits behind head on master.

❗ Current head cc929bc differs from pull request most recent head 14593f9. Consider uploading reports for the commit 14593f9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files          23       23           
  Lines        1078     1080    +2     
=======================================
+ Hits         1043     1045    +2     
  Misses         35       35           
Files Coverage Δ
src/db/models/endpoints.js 100.00% <100.00%> (ø)
src/middleware/initiate.js 98.76% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatthewErispe MatthewErispe merged commit 3d9304e into master Oct 31, 2023
4 checks passed
@MatthewErispe MatthewErispe deleted the TB-181-make-endpoints-unique-by-pattern-and-method branch October 31, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants