Update generator js

[napiergit]

Hi @rcrichton, can you please review and comment on any additions changes you would like to see in the mediator scaffolding. Thanks in advance.

[rcrichton]

@napiergit thanks this is looking good and definitely made my life easier. Some initial comments from building my new mediator:

• Perhaps we should add a default .gitignore file?
• The mediator config come out incorrect, in configDefs there is a parameter routePath however in the config object it is listed as just path. This causes mediator registration to fail.
• I'm wondering if we should remove the openhim module as this won't always be needed (not sure about this)
• If we remove the module above then the test will be empty, maybe we should add a sample test just to show people how tests should be written.

I should have more comments as I dig in, however, what do you think about these so far.

[napiergit]

@rcrichton, thanks for the feedback, will add the .gitignore and fix the config object. I like the idea of a sample app with sample tests. I'm not too sure about the openhim module either (if it is really useful code we could always add it to the openhim-mediator-utils)

[rcrichton]

Change this default to openhie

[rcrichton]

Hey @napiergit in my new mediator I've changed some of the code to be inline with some of my comments here. Maybe you want to use that as a reference to help the changes here? https://github.com/jembi/openhim-mediator-basicauth-map

[rcrichton]

@napiergit quick comment while trying this out. The chalk module isn't in the package.json so it doesn't get installed.

[rcrichton]

Also .nyc_output should be in the .gitignore

[rcrichton]

Sorry one last change. I think maybe should do:

app.all('*', (req, res) => {

Then the mediator listens on all paths. We can then remove the config for the mediatorPath as it's no longer needed (and may confuse the user) and delete the path property from the default channel config which sets it to rather forward the path that it receives rather than set its own. I think that simplifies things. I changed my new mediator to do that.

[rcrichton]

Thanks @napiergit this looks great. Just 3 more comments then this can be merged in 👍

I'm off to Rwanda on Sunday so if you get to this once I've gone, then maybe ask Hannes to do the final review, but once those 3 things are done, I think it's good to go. So may not need a full review.

[napiergit]

Hey @hnnesv, can you please review this when you have a chance as Ryan is afk.

[hnnesv]

typo: understand

[hnnesv]

Thanks @napiergit - it's looking good! Just some minor comments from my side.

[napiergit]

Hey @hnnesv, I have made the changes you asked for, anything else?

[hnnesv]

Nope, looks good to me! 👍