Eamon Bracht #10
Merged
Eamon Bracht #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jemimaabu
requested changes
Jan 31, 2019
| @@ -12,8 +12,9 @@ | |||
| <a target="_blank" href="https://github.com/jemimaabu/find-the-formula" class="github-corner" aria-label="View source on GitHub"><svg width="80" height="80" viewBox="0 0 250 250" style="fill:#000; color:#fff; position: absolute; top: 0; border: 0; right: 0;" aria-hidden="true"><path d="M0,0 L115,115 L130,115 L142,142 L250,250 L250,0 Z"></path><path d="M128.3,109.0 C113.8,99.7 119.0,89.6 119.0,89.6 C122.0,82.7 120.5,78.6 120.5,78.6 C119.2,72.0 123.4,76.3 123.4,76.3 C127.3,80.9 125.5,87.3 125.5,87.3 C122.9,97.6 130.6,101.9 134.4,103.2" fill="currentColor" style="transform-origin: 130px 106px;" class="octo-arm"></path><path d="M115.0,115.0 C114.9,115.1 118.7,116.5 119.8,115.4 L133.7,101.6 C136.9,99.2 139.9,98.4 142.2,98.6 C133.8,88.0 127.5,74.4 143.8,58.0 C148.5,53.4 154.0,51.2 159.7,51.0 C160.3,49.4 163.2,43.6 171.4,40.1 C171.4,40.1 176.1,42.5 178.8,56.2 C183.1,58.6 187.2,61.8 190.9,65.4 C194.5,69.0 197.7,73.2 200.1,77.6 C213.8,80.2 216.3,84.9 216.3,84.9 C212.7,93.1 206.9,96.0 205.4,96.6 C205.1,102.4 203.0,107.8 198.3,112.5 C181.9,128.9 168.3,122.5 157.7,114.1 C157.9,116.9 156.7,120.9 152.7,124.9 L141.0,136.5 C139.8,137.7 141.6,141.9 141.8,141.8 Z" fill="currentColor" class="octo-body"></path></svg></a> | |||
| <div id="display-pattern"></div> | |||
| <input type="text" id="next-number"> | |||
| <button type="button" onclick="guess()">Submit</button> | |||
| <button type="button" class="next-pattern" onclick="nextPattern()">Next</button> | |||
| <!--Added id to button--> | |||
There was a problem hiding this comment.
No need to include comments in HTML, you can mention them in the commit message instead
| <button type="button" onclick="guess()">Submit</button> | ||
| <button type="button" class="next-pattern" onclick="nextPattern()">Next</button> | ||
| <!--Added id to button--> | ||
| <button type="button" id = "submit-button" title=">"onclick="guess()">Submit</button> |
There was a problem hiding this comment.
Maintain spacing throughout attributes
Suggested change
| <button type="button" id = "submit-button" title=">"onclick="guess()">Submit</button> | |
| <button type="button" id="submit-button" title=">" onclick="guess()">Submit</button> |
| @@ -4,27 +4,63 @@ | |||
|
|
|||
| #display-pattern { | |||
| display: inline-block; | |||
|
|
|||
There was a problem hiding this comment.
No need for spaces inside style rule block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styles buttons and text boxes
Description
Motivation and Context
Response to issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: