Add visit_IfExp and tests

CHANGELOG.md

@@ -1,5 +1,6 @@
 # Unreleased
 
+* Detect unreachable code in conditional expressions (#178)
 * Report error codes in output, e.g., `code.py:1: V104 unused import ...`
   (RJ722, #195).
 * Support `# noqa` comments to suppress results from that line

tests/test_conditions.py

@@ -212,3 +212,20 @@ def test_redundant_if(v):
     )
     print(v.unreachable_code[0].size)
     check_unreachable(v, 1, 2, "if")
+
+
+def test_if_exp_true(v):
+    v.scan(
+        """\
+foo if True else bar
+"""
+    )
+    check_unreachable(v, 1, 1, "ternary")
+
+def test_if_exp_false(v):
+    v.scan(
+        """\
+foo if False else bar
+"""
+    )
+    check_unreachable(v, 1, 1, "ternary")

vulture/core.py

@@ -402,17 +402,26 @@ def _add_aliases(self, node):
 
     def _handle_conditional_node(self, node, name):
         if utils.condition_is_always_false(node.test):
+            last_node = node.body if isinstance(node, ast.IfExp) else node.body[-1]
             self._define(
                 self.unreachable_code,
                 name,
                 node,
-                last_node=node.body[-1],
+                last_node=last_node,
                 message="unsatisfiable '{name}' condition".format(**locals()),
                 confidence=100,
             )
         elif utils.condition_is_always_true(node.test):
             else_body = node.orelse
-            if else_body:
+            if name == "ternary":
+                self._define(
+                    self.unreachable_code,
+                    name,
+                    else_body,
+                    message="unreachable 'else' expression",
+                    confidence=100,
+                )
+            elif else_body:
                 self._define(
                     self.unreachable_code,
                     "else",
@@ -575,6 +584,9 @@ def visit_FunctionDef(self, node):
     def visit_If(self, node):
         self._handle_conditional_node(node, "if")
 
+    def visit_IfExp(self, node):
+        self._handle_conditional_node(node, "ternary")
+
     def visit_Import(self, node):
         self._add_aliases(node)