Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean room implementation of 'subset' function #260

Closed
jenetics opened this issue Sep 26, 2017 · 1 comment
Closed

Clean room implementation of 'subset' function #260

jenetics opened this issue Sep 26, 2017 · 1 comment
Assignees
@jenetics
Labels
cleanup
Milestone
v4.0.0

Comments

@jenetics
Copy link
Owner

jenetics commented Sep 26, 2017 •
edited
Loading

The io.jenetics.internal.math.base.subset function might be too narrow on the existing C++ implementation of the ksub_random function. This might lead to copyright problems. To be on the safe side and avoid copyright problems, do a new clean room implementation of this method as described in Combinatorial Algorithms for Computers and Calculators by Albert Nijenhuis and Herbert Wilf; pp. 39.
@jenetics jenetics self-assigned this Sep 26, 2017
@jenetics jenetics added this to the v4.0.0 milestone Sep 26, 2017
@jenetics jenetics changed the title Clean room re-implementation of 'subset' function Clean room implementation of 'subset' function Sep 26, 2017
jenetics added a commit that referenced this issue Oct 3, 2017
@jenetics
#260: New clean code implementation of the 'base.subset' method.
110b490
jenetics added a commit that referenced this issue Oct 3, 2017
@jenetics
#260: Remove 'subset' method in 'base' helper class.
017b503
jenetics added a commit that referenced this issue Oct 3, 2017
@jenetics
#260: Fix code after refactoring.
5fcc7d8
jenetics added a commit that referenced this issue Oct 3, 2017
@jenetics
#260: Fix index of next random 'x'.
88c142c
jenetics added a commit that referenced this issue Oct 3, 2017
@jenetics
#260: Remove println in test.
d9bd618
jenetics added a commit that referenced this issue Oct 3, 2017
@jenetics
Merge pull request #265 from jenetics/issues/JENETICS-260-subset
ebd3c1b 
#260: Subset implementation
@jenetics
Copy link
Owner Author

jenetics commented Oct 3, 2017

Clean room implementation of the following algorithm:
ranksb

Combinatorial Algorithms for Computers and Calculators by Albert Nijenhuis and Herbert Wilf; pp. 42.

@jenetics jenetics closed this as completed Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenetics jenetics

Labels
cleanup
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
1 participant
@jenetics