Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible overflow in Integer/LongGene mean method #791

Closed
jenetics opened this issue Aug 29, 2021 · 1 comment
Closed

Fix possible overflow in Integer/LongGene mean method #791

jenetics opened this issue Aug 29, 2021 · 1 comment
Assignees
@jenetics
Labels
bug
Milestone
v7.0.0

Comments

@jenetics
Copy link
Owner

The IntegerGene::mean and LongGene::mean method my be overflow on negative allele values.

Using (x&y)+((x^y)>>1) for calculating the average of two integer values.

http://aggregate.org/MAGIC/#Average%20of%20Integers
@jenetics jenetics added the bug label Aug 29, 2021
@jenetics jenetics added this to the v7.0.0 milestone Aug 29, 2021
@jenetics jenetics self-assigned this Aug 29, 2021
jenetics added a commit that referenced this issue Aug 29, 2021
@jenetics
#791: Fix Integer/LongGene::mean underflow.
88718b7
jenetics added a commit that referenced this issue Aug 29, 2021
@jenetics
Merge pull request #792 from jenetics/issues/JENETICS-791-mean_overflow
286021f 
#791: Fix Integer/LongGene::mean underflow.
@jenetics
Copy link
Owner Author

Merged into r7.0.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenetics jenetics

Labels
bug
Projects
None yet
Milestone
v7.0.0
Development

No branches or pull requests
1 participant
@jenetics