Add traditional chinese translation #348 #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaulino
reviewed
Mar 14, 2023
src/AmbientSounds.Uwp/MultilingualResources/AmbientSounds.Uwp.zh-TW.xlf
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect #348
Disclaimer: I have not tested it yet on my machine.
Note that the country code is using
TWfor now but I suspect this would work for HK as well. Idk how language lookup work on windows precisely so will need to test if "Traditional chinese (HK)" users see the translation by default.I also notice some odd translation in simplified chinese and inconsistency use of words (e.g. focus => 集中／專注). Maybe they are translated by machine/different people? Could open another issue for review of simplified chinese.