feat(vnets) add 2 public subnets for ci.jenkins.io agents and controller #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
timja
approved these changes
Apr 12, 2023
| virtual_network_name = azurerm_virtual_network.public.name | ||
| address_prefixes = [ | ||
| "10.245.4.0/24", # 10.245.4.1 - 10.245.4.254 | ||
| "fdb5:c0c9:9cfc:7658::/64", # smaller size as it only need to support public IPv6 for ci.jenkins.io controller |
There was a problem hiding this comment.
I know very little about ipv6 as I've never really used it but this seems to show /64 being very big?
https://docs.netgate.com/pfsense/en/latest/network/ipv6/subnets.html
but I could be wrong.
There was a problem hiding this comment.
Went through the same thought process, until I learnt that IETF recommends a /64 for subnets most of the time:
A /64 is a standard size IPv6 subnet as defined by the IETF. It is smallest subnet that can used locally if auto configuration is desired.
Good thing with IPv6, as I understand it, is that overlap won't be a problem as the Prefix cna be used accordingly (compared to the IPv4 CIDR and subnets).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#2981, this PR adds 2 subnets for ci.jenkins.io:
/24) to avoid calculation issues (the10.245.4.xis reserved). It also allows IPv6 private address to anticipate a public IPv6 for ci.jenkins.io (ref. [INFRA-47] *.jenkins-ci.org are not accessible via IPV6 helpdesk#62 and Add AAAA records, support installs IPv6 only environments helpdesk#3227)The goal is to start spinning up VM agents for ci.jenkins in these new subnets, closer to the artifact caching proxy, and prepare of the migration of ci.jenkins.io's to the new public network as well.