Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publick8s) specify pod subnets explicitly #431

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jul 7, 2023

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal marked this pull request as ready for review July 7, 2023 10:56
@dduportal dduportal requested a review from a team as a code owner July 7, 2023 10:56
@dduportal dduportal changed the title Fix/publick8s/pod subnets fix(publick8s) specify pod subnets explicitly Jul 7, 2023
@lemeurherve
Copy link
Member

Without this, pods were allocated an IP in the "public" vnet but not specifically in the "publick8s-tier" subnet. (Some were in 10.244.x.x like the accountapp, which prevented it to access the ldap due to ldap loadBalancerSourceRanges not including it)

Copy link
Contributor Author

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plan: 4 to add, 1 to change, 4 to destroy. /o\

@dduportal dduportal merged commit bc3d4a6 into jenkins-infra:main Jul 7, 2023
7 checks passed
@dduportal dduportal deleted the fix/publick8s/pod-subnets branch July 7, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants