Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(cert,trusted) migrate NAT gateway management to azure-net #567

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jan 5, 2024

While working on jenkins-infra/helpdesk#3875, the need to manage NAT gateways close to network resources appeared.

This PR removes the definitions of the 2 existing NAT gateway so we can start managing them in jenkins-infra/azure-net.

Note that the associated resources (marked as "to be deleted" in the build 1) will be removed manually from the terraform state (see command in the comment below).
Then a 2nd build will be re-triggered before merging, to ensure no changes will be done by this PR.

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal
Copy link
Contributor Author

Command to remove from state:

terraform state rm "azurerm_nat_gateway.cert_ci_jenkins_io_outbound"
terraform state rm "azurerm_nat_gateway" "trusted_outbound"
terraform state rm "azurerm_nat_gateway_public_ip_association" "cert_ci_jenkins_io_outbound"
terraform state rm "azurerm_nat_gateway_public_ip_association" "trusted_outbound"
terraform state rm "azurerm_public_ip" "cert_ci_jenkins_io_outbound"
terraform state rm "azurerm_public_ip" "trusted_outbound"
terraform state rm "azurerm_subnet_nat_gateway_association" "cert_ci_jenkins_io_outbound_controller"
terraform state rm "azurerm_subnet_nat_gateway_association" "cert_ci_jenkins_io_outbound_ephemeral_agents"
terraform state rm "azurerm_subnet_nat_gateway_association" "trusted_outbound_controller"
terraform state rm "azurerm_subnet_nat_gateway_association" "trusted_outbound_ephemeral_agents"
terraform state rm "azurerm_subnet_nat_gateway_association" "trusted_outbound_permanent_agents"

@dduportal
Copy link
Contributor Author

No changes. Your infrastructure matches the configuration. let's merge! 🚀

@dduportal dduportal marked this pull request as ready for review January 5, 2024 11:51
@dduportal dduportal requested a review from a team as a code owner January 5, 2024 11:51
@dduportal dduportal merged commit befe0c5 into jenkins-infra:main Jan 5, 2024
2 checks passed
@dduportal dduportal deleted the cleanup/migrate-nat-gateway-to-azure-net branch January 5, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant