feat: add a new AKS cluster for ci.jenkins.io agents #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
lemeurherve
previously approved these changes
May 10, 2024
dduportal
commented
May 10, 2024
|
This PR failed to deploy with the following classes of errors:
|
dduportal
added a commit
that referenced
this pull request
May 10, 2024
This reverts commit 81f7288.
dduportal
added a commit
that referenced
this pull request
May 10, 2024
dduportal
added a commit
that referenced
this pull request
May 11, 2024
Second tentative at creating the new cluster (after #693 rollbacked by #694) > Related to jenkins-infra/helpdesk#3954 > > Blocked by jenkins-infra/shared-tools#146 > > This PR introduces a new AKS cluster to host ci.jenkins.io container agents workload with the [specified](jenkins-infra/helpdesk#3954 (comment)) attributes: > > - [Private cluster](jenkins-infra/helpdesk#3954 (comment)) (e.g. API not exposed except internally) which means we need cluster to reach it => it might need subsequent PRs to fine-tune the infra.ci.jenkins.io agent network accesses. > - Outbound with NAT gateway and no ingress (as per jenkins-infra/helpdesk#3954 (comment)) > - Initial set of node pools with the [proposed sizings](jenkins-infra/helpdesk#3954 (comment)) > > Notes: > > - Allowing ci.jenkins.io to reach the AKS API of this cluster requires a few additional NSGs rules specified in the `ci.jenkins.io.tf` file > - The PR jenkins-infra/shared-tools#146 is needed so we can set up NSG rules to restrict the agents in and out network requests. The following elements were changed since the first tentative: - Commented out the kubernetes configuration (until infra.ci configuration is tuned to reach the API controle plane) to avoid failing deployment initially (during bootstrap) - Fixed the "inbound agent" module to ensure naming of NSG and its security rule won't fail like they did on the initial deployment (ref. jenkins-infra/shared-tools@f251e97) Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#3954
Blocked by jenkins-infra/shared-tools#146
This PR introduces a new AKS cluster to host ci.jenkins.io container agents workload with the specified attributes:
Notes:
ci.jenkins.io.tffile