Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins helm chart to pull files from infra #101

Merged

Conversation

halkeye
Copy link
Member

@halkeye halkeye commented Jan 7, 2020

No description provided.

@halkeye halkeye requested a review from a team as a code owner January 7, 2020 21:01
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments and I’ll test it out on my machine this morning

memory: 1024Mi
#resources:
# limits:
# cpu: 100m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these are the resources of you are using new mode?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, and honestly probably a lot smaller than that, I don't fully understand the numbers :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty small I wouldn’t go smaller and should be fine for a static site

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ kubectl top pod
NAME                                                      CPU(cores)   MEMORY(bytes)
jenkins-plugins-io-plugin-site-backend-6d7c96d98b-xvb4d   7m           489Mi
jenkins-plugins-io-plugin-site-frontend-9f6665996-ng799   1m           3Mi

charts/plugin-site/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/plugin-site/values.yaml Outdated Show resolved Hide resolved
Comment on lines 33 to 37
cpu: 2000m
memory: 2048Mi
requests:
cpu: 1000m
memory: 1024Mi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend doesn't probably need that amount of memory and cpu.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the javascript version does, I had it set locally to 100m cpu, and it took 15 min to test, compile, and startup.
at 1000m, it took a couple seconds

The old image is really not optimized in any way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to remember to update the resources when we enable the new static site

@timja timja requested a review from olblak January 8, 2020 11:27
…ealy nice caching setup), pointed at a volume mount
@halkeye
Copy link
Member Author

halkeye commented Jan 10, 2020

Tested with flexvolume as I don't have azure:

backend:
  replicaCount: 1
frontend:
  replicaCount: 1

htmlVolume:
  flexVolume:
    driver: juliohm/cifs
    options:
      opts: guest,uid=1000,gid=1000
      server: odin
      share: /gatsby-plugin-site

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t the readme need an update on running locally now that you need static files in place?

@halkeye
Copy link
Member Author

halkeye commented Jan 10, 2020

Doesn’t the readme need an update on running locally now that you need static files in place?

THERES A README??!?!?!?

Um, probably

I'm not sure how you'd run it locally. Does minikube have any sort of local disk mounter?

Should I just document hostpath?

https://kubernetes.io/docs/concepts/storage/volumes/#example-pod-2

@halkeye
Copy link
Member Author

halkeye commented Jan 10, 2020

okay, https://kubernetes.io/docs/concepts/storage/volumes/#hostpath is a better link

Documented

@timja
Copy link
Member

timja commented Jan 10, 2020

Take a look at the other ones that require static files like Jenkins io they are a bit more detailed I think

@timja
Copy link
Member

timja commented Jan 10, 2020

Minikube does have a command to mount a folder to the node, it’s documented in the readme’s that require it

@timja
Copy link
Member

timja commented Jan 10, 2020

@halkeye halkeye changed the title WIP - Support new and old format docker images Update plugins helm chart to pull files from infra Jan 11, 2020
Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>
@olblak
Copy link
Member

olblak commented Jan 13, 2020

I just updated plugin-site credentials and now you should be able to modify that secret file, even if in the current state you can't have access to the azure account

@olblak olblak merged commit 859ceee into jenkins-infra:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants