New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugins helm chart to pull files from infra #101
Update plugins helm chart to pull files from infra #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments and I’ll test it out on my machine this morning
charts/plugin-site/values.yaml
Outdated
memory: 1024Mi | ||
#resources: | ||
# limits: | ||
# cpu: 100m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume these are the resources of you are using new mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, and honestly probably a lot smaller than that, I don't fully understand the numbers :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty small I wouldn’t go smaller and should be fine for a static site
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ kubectl top pod
NAME CPU(cores) MEMORY(bytes)
jenkins-plugins-io-plugin-site-backend-6d7c96d98b-xvb4d 7m 489Mi
jenkins-plugins-io-plugin-site-frontend-9f6665996-ng799 1m 3Mi
charts/plugin-site/values.yaml
Outdated
cpu: 2000m | ||
memory: 2048Mi | ||
requests: | ||
cpu: 1000m | ||
memory: 1024Mi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The frontend doesn't probably need that amount of memory and cpu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the javascript version does, I had it set locally to 100m cpu, and it took 15 min to test, compile, and startup.
at 1000m, it took a couple seconds
The old image is really not optimized in any way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to remember to update the resources when we enable the new static site
…ealy nice caching setup), pointed at a volume mount
Tested with flexvolume as I don't have azure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn’t the readme need an update on running locally now that you need static files in place?
THERES A README??!?!?!? Um, probably I'm not sure how you'd run it locally. Should I just document hostpath? https://kubernetes.io/docs/concepts/storage/volumes/#example-pod-2 |
okay, https://kubernetes.io/docs/concepts/storage/volumes/#hostpath is a better link Documented |
Take a look at the other ones that require static files like Jenkins io they are a bit more detailed I think |
Minikube does have a command to mount a folder to the node, it’s documented in the readme’s that require it |
Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>
I just updated plugin-site credentials and now you should be able to modify that secret file, even if in the current state you can't have access to the azure account |
No description provided.