December 13 2023 - creating Alex Earl spotlight #7
Conversation
|
How about this one? |
|
That's fantastic, thanks very much @slide ! I've downloaded the image and added it accordingly |
|
Is it normal that the image is duplicated in two folders? |
|
@lemeurherve I definitely need to run it through compressor.io & resize it a bit more. I put it in two places because there are a couple of different areas where avatars can be stored, so I was just trying to cover everything. |
|
@lemeurherve I was able to resize and compress the image down to ~200kb |
There was a problem hiding this comment.
Requesting changes to prevent merging this PR until a week or two.
cc @kmartens27
kmartens27
changed the title
|
@kmartens27 Is it okay for me to push a change to this PR? I see two contributors simultaneously featured but I thought we are supposed to spotlight only one at a time and would like to correct this. |
|
@krisstern yes of course! Always feel free to make any changes you see fit. Since this has not been merged yet though, would the featured status matter? I was envisioning leaving this the way it is, and then changing the previous contributor to |
krisstern
changed the title
@kmartens27 I think it would be better to disable the spotlight for the previously featured contributor whilst we spotlight a new contributor, that way we keep it one-at-a-time. I have made the changes accordingly. Please see preview to see if this looks as expected. I will do the same for the next spotlight as well later once this one rolls out. |
|
Hi @krisstern that makes sense! I think we're on the same page and the change is correct. Thanks for setting that up accordingly! |
|
@kmartens27 @krisstern should I approve this PR to unblock it or should it stay as it is until next week? |
|
@lemeurherve I think you can approve it now if the PR looks good to you. We will keep in mind not to merge it until @kmartens27 does so on December 13 next Wednesday. |
|
Everything should be all set, so having it approved & ready for merge makes sense. I'll be sure to merge it on the 13th and we'll get the release schedule started for the next! Thanks very much @krisstern & @lemeurherve for all your help and work on this and everything else! |
|
The preview is looking great! @kmartens27 if we are publishing this today as scheduled we are all good to go! |
|
thanks very much @krisstern, I'm merging this now so that we can get this live & send out the announcement tweet |
This pull request is for the creation of @slide contributor spotlight page.
The date included in the title is the planned publication date of the spotlight page. This will be 2 weeks from the publication of the previous spotlight (going forward). The date of December 4 may change, depending on when the first spotlight is published. If that needs to be updated, it will be adjusted accordingly.
@slide is there another image that you would be okay with using? Currently, the profile picture on GitHub only includes your eyes/forehead area, and ideally we would have clear images to use. However, if you are not comfortable with that or have any reservations about this, we can proceed with what we have! Additionally, please provide any feedback or suggestions you might have and I'll be sure to update things as needed.