Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Get rid of images directory at src/ #8

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix: Get rid of images directory at src/ #8

merged 2 commits into from
Nov 21, 2023

Conversation

krisstern
Copy link
Member

To clean up the codebase and remove the extra images directory at src, so that there would be no confusion that we are using static for storing images.

@krisstern
Copy link
Member Author

Hi @kmartens27 Could you approve this PR as I updated some config for the src/images directory so we could safely remove the entire folder from src?

kmartens27
kmartens27 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic, thanks very much @krisstern !!

@krisstern krisstern merged commit bb1d856 into jenkins-infra:main Nov 21, 2023
@krisstern krisstern deleted the fix/patch-duplicated-image-directory branch November 21, 2023 16:05
@lemeurherve lemeurherve mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmartens27 kmartens27 kmartens27 approved these changes

@alyssat alyssat Awaiting requested review from alyssat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krisstern @kmartens27