Skip to content
This repository has been archived by the owner on Jan 18, 2020. It is now read-only.

[JENKINS-51735] sentry evaluation #133

Closed
wants to merge 4 commits into from
Closed

[JENKINS-51735] sentry evaluation #133

wants to merge 4 commits into from

Conversation

mandie722
Copy link
Contributor

https://issues.jenkins-ci.org/browse/JENKINS-51735

Added in methods to send output to sentry.io from the error telemetry apis.

@mandie722 mandie722 requested review from batmat and rtyler July 10, 2018 19:32
@jenkinsadmin
Copy link

Build failed; the context from the latest run is:

Expand to view 
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Build backend container)
Stage "Build backend container" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Test images)
Stage "Test images" skipped due to earlier failure(s)
[Pipeline] parallel
[Pipeline] [Base image] { (Branch: Base image)
[Pipeline] [Docker Cloud image] { (Branch: Docker Cloud image)
[Pipeline] [Base image] stage
[Pipeline] [Base image] { (Base image)
[Pipeline] [Docker Cloud image] stage
[Pipeline] [Docker Cloud image] { (Docker Cloud image)
Stage "Base image" skipped due to earlier failure(s)
Stage "Docker Cloud image" skipped due to earlier failure(s)
[Pipeline] [Base image] }
[Pipeline] [Docker Cloud image] }
[Pipeline] [Base image] // stage
[Pipeline] [Docker Cloud image] // stage
[Pipeline] [Base image] }
[Base image] Failed in branch Base image
[Pipeline] [Docker Cloud image] }
[Docker Cloud image] Failed in branch Docker Cloud image
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Publish jenkins/evergreen)
Stage "Publish jenkins/evergreen" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timestamps
[Pipeline] }
[Pipeline] // timeout
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline

GitHub has been notified of this commit’s build result

ERROR: script returned exit code 2
Finished: FAILURE

Powered by the Comment Logger

@jenkinsadmin
Copy link

Build failed; the context from the latest run is:

Expand to view 
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Build backend container)
Stage "Build backend container" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Test images)
Stage "Test images" skipped due to earlier failure(s)
[Pipeline] parallel
[Pipeline] [Base image] { (Branch: Base image)
[Pipeline] [Docker Cloud image] { (Branch: Docker Cloud image)
[Pipeline] [Base image] stage
[Pipeline] [Base image] { (Base image)
[Pipeline] [Docker Cloud image] stage
[Pipeline] [Docker Cloud image] { (Docker Cloud image)
Stage "Base image" skipped due to earlier failure(s)
Stage "Docker Cloud image" skipped due to earlier failure(s)
[Pipeline] [Base image] }
[Pipeline] [Docker Cloud image] }
[Pipeline] [Base image] // stage
[Pipeline] [Docker Cloud image] // stage
[Pipeline] [Base image] }
[Base image] Failed in branch Base image
[Pipeline] [Docker Cloud image] }
[Docker Cloud image] Failed in branch Docker Cloud image
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Publish jenkins/evergreen)
Stage "Publish jenkins/evergreen" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timestamps
[Pipeline] }
[Pipeline] // timeout
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline

GitHub has been notified of this commit���s build result

ERROR: script returned exit code 2
Finished: FAILURE

Powered by the Comment Logger

@jenkinsadmin
Copy link

Build failed; the context from the latest run is:

Expand to view 
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Build backend container)
Stage "Build backend container" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Test images)
Stage "Test images" skipped due to earlier failure(s)
[Pipeline] parallel
[Pipeline] [Base image] { (Branch: Base image)
[Pipeline] [Docker Cloud image] { (Branch: Docker Cloud image)
[Pipeline] [Base image] stage
[Pipeline] [Base image] { (Base image)
[Pipeline] [Docker Cloud image] stage
[Pipeline] [Docker Cloud image] { (Docker Cloud image)
Stage "Base image" skipped due to earlier failure(s)
Stage "Docker Cloud image" skipped due to earlier failure(s)
[Pipeline] [Base image] }
[Pipeline] [Docker Cloud image] }
[Pipeline] [Base image] // stage
[Pipeline] [Docker Cloud image] // stage
[Pipeline] [Base image] }
[Base image] Failed in branch Base image
[Pipeline] [Docker Cloud image] }
[Docker Cloud image] Failed in branch Docker Cloud image
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Publish jenkins/evergreen)
Stage "Publish jenkins/evergreen" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timestamps
[Pipeline] }
[Pipeline] // timeout
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline

GitHub has been notified of this commit’s build result

ERROR: script returned exit code 2
Finished: FAILURE

Powered by the Comment Logger

@batmat
Copy link
Collaborator

batmat commented Jul 11, 2018

Error looks legit. Closing this to avoid it to rebuild every 6 hours @mandie722, just reopen it when you're back and think you fixed the issue. Thanks

@batmat batmat closed this Jul 11, 2018
@batmat batmat changed the title Jenkins 51735 sentry evaluation [JENKINS-51735] sentry evaluation Jul 11, 2018
batmat
batmat reviewed Jul 11, 2018
View reviewed changes
services/src/services/errorTelemetry/errorTelemetry.class.js
@@ -27,9 +27,9 @@ class ErrorTelemetryService {
return Promise.reject({status:'KO'});
}

// FIXME: TBD where, what and how to actually send data
const toWrite = `${new Date()} => ${JSON.stringify(data)}\n\n`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that comment should be removed yet, or the format should be evolved a bit. As it is now, it's sending a somewhat still raw: "date (without defined format) => the json of the log", which I fear is not going to be greatly parsed by Sentry is it? Anyway, I guess we should clean up that too.

services/src/services/errorTelemetry/errorTelemetry.class.js
@@ -2,7 +2,7 @@ const fs = require('fs');
const logger = require('winston');
const path = require('path');
const mkdirp = require('mkdirp');

const sentry = require('../../lib/sentry');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI error seems to come from this. I seem to understand the raven module got imported above, but then the code references a manually (?) added lib from two directories above?

I seem to understand that the line above should just be replaced by

const sentry = require('raven');

And then it would work?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@batmat batmat batmat left review comments

@rtyler rtyler Awaiting requested review from rtyler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mandie722 @jenkinsadmin @batmat