Providing feedback on the booting process to users #203
Conversation
Build failed; the context from the latest run is: Expand to view
|
530a07d
to
fa90740
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, much nice! Very demo effect!
distribution/www/502.html
Outdated
<div class="centered"> | ||
<img src="evergreen-static/demon_256.png" | ||
title="Jenkins Evergreen Error!" | ||
alt="Jenkins Evergreen isn't too magical!"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
distribution/www/521.html
Outdated
<div> | ||
<p> | ||
Jenkins Evergreen is an automatically updating rolling | ||
distribution system for Jenkins It consists of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Missing period
@@ -57,11 +58,22 @@ RUN apk add --no-cache git \ | |||
ttf-dejavu \ | |||
curl \ | |||
socat \ | |||
wget | |||
wget \ | |||
nginx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a specific issue, so I think that's fine. But we'll need to consider how we want users to get updates for system wide installed components such as this. (Issue already existing for docker
too, for instance).
@@ -1,4 +1,4 @@ | |||
FROM node:9-alpine | |||
FROM node:10-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AIUI, from an upgrade experience perspective, we'll want users to periodically do a manual switch by pulling the latest image, and re-running a new container (while keeping the volume). If they do not, they won't get this kind of update, not sure we have an easy way out here. (well, I'm sure the way out is not easy, phrased differently 😈).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, I've thought about this kind of thing a lot over the past couple weeks. Part of the motivation to get this user feedback system is to allow us to inform the users a new container being present (hopefully)
fa90740
to
d9199f4
Compare
This will help the nginx frontend display the right page when Jenkins Evergreen is getting started
…er socket.io This is a bit of a pain to integration test, since we really need to rebuild the whole container between round-trips Related to JENKINS-53227
d9199f4
to
efeb561
Compare
Build failed; the context from the latest run is: Expand to view
|
This simplifies development a bit and makes it easier to view the status page straight from a client's `make run`
This has been tested in a container and outside of one
efeb561
to
3f125f4
Compare
@@ -45,7 +45,7 @@ docker volume create jenkins-evergreen-data && \ | |||
docker run --name evergreen \ | |||
--restart=always \ | |||
-ti \ | |||
-p 8080:8080 \ | |||
-p 8080:80 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting issue I just hit because of this: this docs got updated immediately, when for some reason, the public Docker image seems to be still not updated for some reason. So Running the docs as is was binding 8080 to 80, but my local image does not have nginx
yet. (yes, I did a docker pull
in case)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR, the updated image has been updated now.
There's still some more work I need to do here to build a little status app inside
evergreen-client