Skip to content
This repository has been archived by the owner on Jan 18, 2020. It is now read-only.

Providing feedback on the booting process to users #203

Merged
merged 9 commits into from Aug 29, 2018

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Aug 27, 2018

There's still some more work I need to do here to build a little status app inside evergreen-client

@rtyler rtyler added the work-in-progress Not quite ready for review label Aug 27, 2018
@jenkinsadmin
Copy link

Build failed; the context from the latest run is:

Expand to view
Post stage
[AWS Cloud image (smokes)] �[3A�[2K
Stopping distribution_instance_1 ... �[32mdone�[0m
�[3B�[2A�[2K
Stopping distribution_backend_1  ... �[32mdone�[0m
�[2B�[1A�[2K
Stopping distribution_db_1       ... �[32mdone�[0m
�[1BRemoving distribution_instance_1 ... 
[AWS Cloud image (smokes)] Removing distribution_backend_1  ... 
[AWS Cloud image (smokes)] Removing distribution_db_1       ... 
[AWS Cloud image (smokes)] �[1A�[2K
Removing distribution_db_1       ... �[32mdone�[0m
�[1B�[3A�[2K
Removing distribution_instance_1 ... �[32mdone�[0m
�[3B�[2A�[2K
Removing distribution_backend_1  ... �[32mdone�[0m
�[2BRemoving network distribution_default
[AWS Cloud image (smokes)] G'day!
[AWS Cloud image (smokes)] 
[AWS Cloud image (smokes)] Ran 6 tests.
[AWS Cloud image (smokes)] 
[AWS Cloud image (smokes)] FAILED (failures=2)
[AWS Cloud image (smokes)] Makefile:44: recipe for target 'aws-cloud-container-check' failed
[AWS Cloud image (smokes)] make: *** [aws-cloud-container-check] Error 1
[AWS Cloud image (smokes)] make: Leaving directory '/home/jenkins/workspace/Infra_evergreen_PR-203-LVWRSS6XSF2GMZTKQVYYLOI7GSVE6J775JF3DWSEYOD3FNOJPM5A/distribution'
[Pipeline] [AWS Cloud image (smokes)] archiveArtifacts
[AWS Cloud image (smokes)] Archiving artifacts
[Pipeline] [AWS Cloud image (smokes)] }
[Pipeline] [AWS Cloud image (smokes)] // withEnv
[Pipeline] [AWS Cloud image (smokes)] }
[Pipeline] [AWS Cloud image (smokes)] // node
[Pipeline] [AWS Cloud image (smokes)] }
[Pipeline] [AWS Cloud image (smokes)] // stage
[Pipeline] [AWS Cloud image (smokes)] }
[AWS Cloud image (smokes)] Failed in branch AWS Cloud image (smokes)
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Publish jenkins/evergreen)
Stage "Publish jenkins/evergreen" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timestamps
[Pipeline] }
[Pipeline] // timeout
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline

GitHub has been notified of this commit’s build result

ERROR: script returned exit code 2
Finished: FAILURE

Powered by the Comment Logger

Copy link
Collaborator

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, much nice! Very demo effect!

<div class="centered">
<img src="evergreen-static/demon_256.png"
title="Jenkins Evergreen Error!"
alt="Jenkins Evergreen isn't too magical!"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

<div>
<p>
Jenkins Evergreen is an automatically updating rolling
distribution system for Jenkins It consists of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Missing period

@@ -57,11 +58,22 @@ RUN apk add --no-cache git \
ttf-dejavu \
curl \
socat \
wget
wget \
nginx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a specific issue, so I think that's fine. But we'll need to consider how we want users to get updates for system wide installed components such as this. (Issue already existing for docker too, for instance).

@@ -1,4 +1,4 @@
FROM node:9-alpine
FROM node:10-alpine
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AIUI, from an upgrade experience perspective, we'll want users to periodically do a manual switch by pulling the latest image, and re-running a new container (while keeping the volume). If they do not, they won't get this kind of update, not sure we have an easy way out here. (well, I'm sure the way out is not easy, phrased differently 😈).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, I've thought about this kind of thing a lot over the past couple weeks. Part of the motivation to get this user feedback system is to allow us to inform the users a new container being present (hopefully)

R. Tyler Croy added 5 commits August 29, 2018 07:16
This will help the nginx frontend display the right page when Jenkins Evergreen
is getting started
…er socket.io

This is a bit of a pain to integration test, since we really need to rebuild the
whole container between round-trips

Related to JENKINS-53227
@rtyler rtyler removed the work-in-progress Not quite ready for review label Aug 29, 2018
@jenkinsadmin
Copy link

Build failed; the context from the latest run is:

Expand to view
[Pipeline] parallel
[Pipeline] [Base image] { (Branch: Base image)
[Pipeline] [Docker Cloud image] { (Branch: Docker Cloud image)
[Pipeline] [AWS Cloud image (smokes)] { (Branch: AWS Cloud image (smokes))
[Pipeline] [Base image] stage
[Pipeline] [Base image] { (Base image)
[Pipeline] [Docker Cloud image] stage
[Pipeline] [Docker Cloud image] { (Docker Cloud image)
[Pipeline] [AWS Cloud image (smokes)] stage
[Pipeline] [AWS Cloud image (smokes)] { (AWS Cloud image (smokes))
Stage "Base image" skipped due to earlier failure(s)
Stage "Docker Cloud image" skipped due to earlier failure(s)
Stage "AWS Cloud image (smokes)" skipped due to earlier failure(s)
[Pipeline] [Base image] }
[Pipeline] [Docker Cloud image] }
[Pipeline] [AWS Cloud image (smokes)] }
[Pipeline] [Base image] // stage
[Pipeline] [Docker Cloud image] // stage
[Pipeline] [AWS Cloud image (smokes)] // stage
[Pipeline] [Base image] }
[Base image] Failed in branch Base image
[Pipeline] [Docker Cloud image] }
[Docker Cloud image] Failed in branch Docker Cloud image
[Pipeline] [AWS Cloud image (smokes)] }
[AWS Cloud image (smokes)] Failed in branch AWS Cloud image (smokes)
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Publish jenkins/evergreen)
Stage "Publish jenkins/evergreen" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timestamps
[Pipeline] }
[Pipeline] // timeout
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline

GitHub has been notified of this commit’s build result

ERROR: script returned exit code 2
Finished: FAILURE

Powered by the Comment Logger

R. Tyler Croy added 3 commits August 29, 2018 10:55
This simplifies development a bit and makes it easier to view the status page
straight from a client's `make run`
This has been tested in a container and outside of one
@rtyler rtyler merged commit 3f5e049 into jenkins-infra:master Aug 29, 2018
@rtyler rtyler deleted the integrity-checks-53227 branch August 29, 2018 20:32
@@ -45,7 +45,7 @@ docker volume create jenkins-evergreen-data && \
docker run --name evergreen \
--restart=always \
-ti \
-p 8080:8080 \
-p 8080:80 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting issue I just hit because of this: this docs got updated immediately, when for some reason, the public Docker image seems to be still not updated for some reason. So Running the docs as is was binding 8080 to 80, but my local image does not have nginx yet. (yes, I did a docker pull in case)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, the updated image has been updated now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants