Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM link missingfor several plugins #3190

Closed
zbynek opened this issue Oct 19, 2022 · 2 comments · Fixed by jenkins-infra/update-center2#649
Closed

SCM link missingfor several plugins #3190

zbynek opened this issue Oct 19, 2022 · 2 comments · Fixed by jenkins-infra/update-center2#649

Comments

@zbynek
Copy link

zbynek commented Oct 19, 2022

Service(s)

Update center

Summary

Continued from #3181 :

"alibabacloud-credentials", "alibabacloud-ecs", "codebeamer-xunit-uploader", "lambdatest-automation", "r7insight-log-forwarder" "vrealize-automation-8"

for these 6 extensions even SCM url is missing from update-center-actual.json. Since SCM URL can't be obtained from their POMs, update-center2 should use this fallback:
https://github.com/jenkins-infra/update-center2/blob/33273a62564d5259b9dfdfd6f891fe812d32eee4/src/main/java/io/jenkins/update_center/HPI.java#L478 but that somehow fails (?) GitHub API problem?

Reproduction steps

  1. Open https://updates.jenkins.io/current/update-center.actual.json in browser
  2. type Object.values(JSON.parse(document.body.innerText).plugins).filter(p=>p.title.includes('Alibaba')).map(p=>p.scm)

Expected: array with 2 URLs
Actual: [undefined, undefined]

@zbynek zbynek added the triage Incoming issues that need review label Oct 19, 2022
@zbynek
Copy link
Author

zbynek commented Oct 20, 2022

minimal failing test:

 @Test
    public void getRepos() {
        System.setProperty("GITHUB_USERNAME", "<username>");
        System.setProperty("GITHUB_PASSWORD", "ghp_<secret>");  /
        assertTrue(GitHubSource.getInstance().isRepoExisting("https://github.com/jenkinsci/alibabacloud-credentials-plugin"));
    }

@zbynek
Copy link
Author

zbynek commented Oct 22, 2022

OK now, maybe GitHub fixed the issue in their API (?)

@zbynek zbynek closed this as completed Oct 22, 2022
@dduportal dduportal removed the triage Incoming issues that need review label Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants