Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant limited access to release.ci to some security team folks #3426

Closed
daniel-beck opened this issue Mar 6, 2023 · 5 comments · Fixed by jenkins-infra/kubernetes-management#3775

Comments

@daniel-beck
Copy link

Service(s)

release.ci.jenkins.io

Summary

@Kevin-CB and @yaroslavafenkin are on the Jenkins security team and it would be useful if they were able to scan branches, trigger builds, and cancel builds on https://release.ci.jenkins.io/job/core/

https://github.com/jenkins-infra/kubernetes-management/blob/49f302fd024e4a9d23e8e0cb080b030f4d034265/config/ext_jenkins-release.yaml#L626-L631 seems to govern permissions. Right now there's only readers and admins. It's probably a good idea to make security team members not admins by default.

Reproduction steps

No response

@daniel-beck daniel-beck added the triage Incoming issues that need review label Mar 6, 2023
@timja
Copy link
Member

timja commented Mar 6, 2023

Approved 👍, and agree it would be good to not make people admin by default for people who can trigger builds.

@dduportal
Copy link
Contributor

For info, blocked by #3428 (until the jenkins-infra team is able to apply configuration changes again).

@dduportal dduportal added this to the infra-team-sync-2023-03-07 milestone Mar 6, 2023
@dduportal
Copy link
Contributor

dduportal commented Mar 6, 2023

Good idea! We're going to propose an improved RBAC (which include jensec members) here before any PR to ensure we all align

@lemeurherve
Copy link
Member

FTR, @Kevin-CB has now access to the private VPN allowing him to go to release.ci.jenkins.io: jenkins-infra/docker-openvpn#252

We need to do the same for @yaroslavafenkin then adapt permissions.

@lemeurherve
Copy link
Member

@Kevin-CB @yaroslavafenkin I've confirmed with you that you have access to private.vpn.jenkins.io and release.ci.jenkins.io, and I've added your kevingrdj & yafenkin jenkins users to the release-core-dev group.

When the following PR will be merged this issue will be completed: jenkins-infra/kubernetes-management#3775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants