Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To host versioned jenkins.io docs on docs.jenkins.io #3885

Closed
krisstern opened this issue Jan 3, 2024 · 19 comments
Closed

To host versioned jenkins.io docs on docs.jenkins.io #3885

krisstern opened this issue Jan 3, 2024 · 19 comments

Comments

@krisstern
Copy link
Member

Service(s)

Helpdesk, jenkins.io

Summary

As one of the outcomes of the GSoC 2023 "Building jenkins.io with alternative tools" project we have come up with a draft of the versioned docs to be tested by the Jenkins community, especially the copy editors. As discussed previously, our desire is to have the Antora site hosted at docs.jennkins.io. The repo has been imported to https://github.com/jenkins-infra/jenkins-io-docs, and is ready to deploy. The Antora playbook needed for production is at https://github.com/jenkins-infra/jenkins-io-docs/blob/main/playbook/antora-playbook.yml. We have tested the setup locally which has been made possible with the local version of the Antora playbook and also the Makefile at the root.

Reproduction steps

No response

@krisstern krisstern added the triage Incoming issues that need review label Jan 3, 2024
@jenkins-infra-helpdesk-app jenkins-infra-helpdesk-app bot added helpdesk Infrastructure related issues management in Github jenkins.io labels Jan 3, 2024
@dduportal dduportal added this to the infra-team-sync-2024-01-09 milestone Jan 3, 2024
@lemeurherve lemeurherve self-assigned this Jan 8, 2024
@lemeurherve
Copy link
Member

@krisstern I'll take care of it.

Optional suggestion: WDYT of docs.jenkins.io as repository name instead of jenkins-io-docs?

@lemeurherve lemeurherve removed the triage Incoming issues that need review label Jan 8, 2024
@krisstern
Copy link
Member Author

Sounds good @lemeurherve!

Sure, docs.jenkins.io would be a better name for the repo.

@dduportal dduportal modified the milestones: infra-team-sync-2024-01-09, infra-team-sync-2024-01-16 Jan 10, 2024
@lemeurherve
Copy link
Member

Update: repository renamed, I need to write a runbook for contributors.jenkins.io and docs.jenkins.io.

@smerle33 smerle33 modified the milestones: infra-team-sync-2024-01-16, infra-team-sync-2024-01-23 Jan 16, 2024
@lemeurherve
Copy link
Member

No progress since last update as other issues were prioritized.

lemeurherve added a commit to jenkins-infra/azure that referenced this issue May 2, 2024
This PR adds the storage account and file share that will be used by the
nginx-website release on publick8s cluster to serve on
docs.origin.jenkins.io the content generated from
https://github.com/jenkins-infra/docs.jenkins.io/.

Ref:
-
jenkins-infra/helpdesk#3885 (comment)
@lemeurherve
Copy link
Member

The CI part is now ready.

Next: add docs.jenkins.io to the publick8s cluster then add the deployment stage to the pipeline.

@lemeurherve
Copy link
Member

Which teams should be affected to https://github.com/jenkins-infra/docs.jenkins.io instead of the individual collaborators currently set as admin?

Taking https://github.com/jenkins-infra/jenkins.io for inspiration, I propose to set the following teams & permissions:

  1. https://github.com/orgs/jenkins-infra/teams/core as admin
  2. https://github.com/orgs/jenkins-infra/teams/security as admin
  3. https://github.com/orgs/jenkins-infra/teams/board as admin
  4. https://github.com/orgs/jenkins-infra/teams/copy-editors as writer
  5. Create a new "docs.jenkins.io" team dedicated to maintaining Antora, and add it as maintainer

WDYT @krisstern @MarkEWaite @kmartens27?

@lemeurherve
Copy link
Member

https://docs.jenkins.io/ is live 🚀

Next: add the deployment stage to the pipeline.

@krisstern
Copy link
Member Author

Which teams should be affected to https://github.com/jenkins-infra/docs.jenkins.io instead of the individual collaborators currently set as admin?

Taking https://github.com/jenkins-infra/jenkins.io for inspiration, I propose to set the following teams & permissions:

  1. https://github.com/orgs/jenkins-infra/teams/core as admin
  2. https://github.com/orgs/jenkins-infra/teams/security as admin
  3. https://github.com/orgs/jenkins-infra/teams/board as admin
  4. https://github.com/orgs/jenkins-infra/teams/copy-editors as writer
  5. Create a new "docs.jenkins.io" team dedicated to maintaining Antora, and add it as maintainer

WDYT @krisstern @MarkEWaite @kmartens27?

Sounds like a good plan for me @lemeurherve! No objections from me.

@kmartens27
Copy link
Collaborator

Which teams should be affected to https://github.com/jenkins-infra/docs.jenkins.io instead of the individual collaborators currently set as admin?

Taking https://github.com/jenkins-infra/jenkins.io for inspiration, I propose to set the following teams & permissions:

  1. https://github.com/orgs/jenkins-infra/teams/core as admin
  2. https://github.com/orgs/jenkins-infra/teams/security as admin
  3. https://github.com/orgs/jenkins-infra/teams/board as admin
  4. https://github.com/orgs/jenkins-infra/teams/copy-editors as writer
  5. Create a new "docs.jenkins.io" team dedicated to maintaining Antora, and add it as maintainer

WDYT @krisstern @MarkEWaite @kmartens27?

That sounds great to me @lemeurherve, thank you for all the work on this!

@MarkEWaite
Copy link

Which teams should be affected to https://github.com/jenkins-infra/docs.jenkins.io instead of the individual collaborators currently set as admin?

Taking https://github.com/jenkins-infra/jenkins.io for inspiration, I propose to set the following teams & permissions:

  1. https://github.com/orgs/jenkins-infra/teams/core as admin
  2. https://github.com/orgs/jenkins-infra/teams/security as admin
  3. https://github.com/orgs/jenkins-infra/teams/board as admin
  4. https://github.com/orgs/jenkins-infra/teams/copy-editors as writer
  5. Create a new "docs.jenkins.io" team dedicated to maintaining Antora, and add it as maintainer

WDYT @krisstern @MarkEWaite @kmartens27?

That makes sense to me. Thanks!

@lemeurherve
Copy link
Member

lemeurherve commented May 6, 2024

About the 5th point, I'm wondering if instead of A) creating a new team including Kriss, Kevin, Mark (current individuals with permission on this repo) we could B) use the existing team https://github.com/orgs/jenkins-infra/teams/docs as maintainers.

It would requires @krisstern to be added to this team in order to continue maintaining docs.jenkins.io repo.

WDYT?

(cc @daniel-beck & @dduportal as member of the docs team)

@MarkEWaite
Copy link

se the existing team https://github.com/orgs/jenkins-infra/teams/docs as maintainers.

That would be fine for me as well.

@dduportal
Copy link
Contributor

About the 5th point, I'm wondering if instead of A) creating a new team including Kriss, Kevin, Mark (current individuals with permission on this repo) we could B) use the existing team https://github.com/orgs/jenkins-infra/teams/docs as maintainers.

It would requires @krisstern to be added to this team in order to continue maintaining docs.jenkins.io repo.

WDYT?

(cc @daniel-beck & @dduportal as member of the docs team)

Fine for me. It would grant the following permissions to Kris:

Capture d’écran 2024-05-06 à 16 42 43

@lemeurherve
Copy link
Member

I added @krisstern to the docs team and set all https://github.com/jenkins-infra/docs.jenkins.io permissions as follow:

image

@lemeurherve
Copy link
Member

lemeurherve commented May 6, 2024

As noted in the plan, it would be wise to add a common prefix to the versioned doc branch names so we could target them with a pattern for branch protections. Something like "version-2.426.x" for example.

@dduportal
Copy link
Contributor

version

stable-2.426.x ?

@dduportal
Copy link
Contributor

https://docs.jenkins.io is live! As far as I can tell, we can close the issue. Many thanks y'all!

@krisstern
Copy link
Member Author

Thank you everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants