Build PR CI check stuck for jenkins-infra/contributor-spotlight

[krisstern]

Service(s)

Helpdesk

Summary

The Build PR check seems to be stuck at incomplete for indefinitely in jenkins-infra/contributor-spotlight#65.

Reproduction steps

No response

[dduportal]

At first sight, this behavior is a consequence of the removal of the github-autostatus plugin (in #3880 (comment)) which was publishing each pipeline stage as a Github check by default.

We added branch protection rules relying on these checks resulting in this behavior.

Another example in jenkins-infra/helm-charts#1003:

[dduportal]

What to do about it:

• Short term (cc @krisstern) if the check is not marked as "Required", and all the others checks are green, it means you can proceed to merge. Next PRs (opened after the 4th January) should not have this check anymore if i'm not mistaken
• We'll have to update job configurations where we can afford punlishing steps such as jenkins-infra/contributor-spotlight
  to configure the github checks (the helm chart used for infra.ci jobs definition allows specifying custom check name along with enabling/disabling it)
• For other jobs, we'll have to either relax branch protection constraint (e.g. rmeoving the disappeared checks) are add explicit publishCheck() in the related pipelines

[dduportal]

• Updated the jobs configurations with feat(privatek8s) infra.ci: enable github checks for updatecli and contributor-spotlight jobs kubernetes-management#4836
• Updated branch protection rules in jenkins-infra/contributor-spotlight, jenkins-infra/kubernetes-management, jenkins-infra/helm-charts and jenkins-infra/jenkins-infra to use the new checks instead of the "disappeared" ones
• The PR fix(deps): update material-ui monorepo to v5.15.3 contributor-spotlight#65 was all green after these changes. Merged it (as it was approved by @krisstern).
• Updated the 2 other PRs to see the same change happening: January 10 2024 - Kris Stern contributor spotlight contributor-spotlight#44 and January 23 2024 - adding Ulli Hafner's spotlight contributor-spotlight#50: all checks are green now

[dduportal]

We can close this issue: note for the users of infra.ci, please reopen with details if you see other jobs with the same problem.

[dduportal]

• https://github.com/jenkins-infra/digitalocean/settings/branches updated to only require the top-level check (pr-merge) as the stages Production and Staging azre not published as GH check anymore