Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace code-coverage-api with coverage #3880

Closed
NotMyFault opened this issue Dec 29, 2023 · 6 comments
Closed

Replace code-coverage-api with coverage #3880

NotMyFault opened this issue Dec 29, 2023 · 6 comments

Comments

@NotMyFault
Copy link
Member

Service(s)

ci.jenkins.io

Summary

code-coverage-api is deprecated in favor its successor; coverage

Reproduction steps

No response

@NotMyFault NotMyFault added the triage Incoming issues that need review label Dec 29, 2023
@dduportal dduportal self-assigned this Dec 30, 2023
@dduportal dduportal removed the triage Incoming issues that need review label Dec 30, 2023
@dduportal dduportal added this to the infra-team-sync-2024-01-02 milestone Dec 30, 2023
@dduportal
Copy link
Contributor

  • Approved, merged and deployed
  • Removed the deprecated plugin in ci.jenkins.io
  • Restarted the controller: no more depreciation message

@dduportal dduportal reopened this Jan 2, 2024
@dduportal
Copy link
Contributor

Reopening as both release.ci and infra.ci seems to also have this plugin installed:

Capture d’écran 2024-01-02 à 15 23 46

@NotMyFault
Copy link
Member Author

Reopening as both release.ci and infra.ci seems to also have this plugin installed:

Capture d’écran 2024-01-02 à 15 23 46

Thanks for checking, I didn't take a look at the other instances 👀

@dduportal dduportal assigned smerle33 and unassigned dduportal Jan 2, 2024
smerle33 added a commit to jenkins-infra/docker-jenkins-lts that referenced this issue Jan 2, 2024
as per jenkins-infra/helpdesk#3880

as Cobertura had dependency on old code-coverage-api and is not used anymore, let's remove it.
dduportal added a commit to jenkins-infra/docker-jenkins-lts that referenced this issue Jan 2, 2024
* feat: replace `code-coverage-api` plugin by `coverage`

* feat(plugins): removing Cobertura plugin

as per jenkins-infra/helpdesk#3880

as Cobertura had dependency on old code-coverage-api and is not used anymore, let's remove it.

---------

Co-authored-by: Stéphane MERLE <95630726+smerle33@users.noreply.github.com>
@dduportal
Copy link
Contributor

dduportal added a commit to dduportal/docker-jenkins-weekly that referenced this issue Jan 3, 2024
Ref. jenkins-infra/helpdesk#3880 (comment)

- This plugin has not been updated since 4 years (ref. https://plugins.jenkins.io/github-autostatus/dependencies/)
- It should be replaced by github-checks (https://plugins.jenkins.io/github-checks/)

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal
Copy link
Contributor

* Alas it appeared that `cobertura` is a dependency of `github-autostatus`: https://plugins.jenkins.io/github-autostatus/dependencies/ . This plugin is not needed (replaced by `github-checks`) so we'll remove it as well

Notes: to check these dependencies, checking the build logs of the released container image shows the output of the jenkins-plugin-cli step in the Dockerfile which describes dependency chains:

18:00:41  #10 2.999 Setting checksum for: github-autostatus to id2Tc+2qh9NfytsbwJMvfhb07XhdPsKOnTJimd/Nqnk=
18:00:41  #10 2.999 Setting checksum for: github-autostatus to id2Tc+2qh9NfytsbwJMvfhb07XhdPsKOnTJimd/Nqnk=
18:00:41  #10 3.000 
18:00:41  #10 3.000 github-autostatus depends on: 
18:00:41  #10 3.000 workflow-api 2.34
18:00:41  #10 3.000 cobertura 1.12.1
18:00:41  #10 3.000 github-branch-source 2.5.8
18:00:41  #10 3.000 jacoco 2.2.1
18:00:41  #10 3.000 pipeline-model-api 1.5.1
18:00:41  #10 3.000 pipeline-model-definition 1.5.1
18:00:41  #10 3.000 Skipping dependency workflow-api:2.34 and its sub-dependencies, because there is a higher version defined on the top level - workflow-api:1283.v99c10937efcb_
18:00:41  #10 3.001 Skipping dependency github-branch-source:2.5.8 and its sub-dependencies, because there is a higher version defined on the top level - github-branch-source:1767.va_7d01ea_c7256
18:00:41  #10 3.001 Skipping dependency jacoco:2.2.1 and its sub-dependencies, because there is a higher version defined on the top level - jacoco:3.3.5
18:00:41  #10 3.002 Skipping dependency pipeline-model-api:1.5.1 and its sub-dependencies, because there is a higher version defined on the top level - pipeline-model-api:2.2151.ve32c9d209a_3f
18:00:41  #10 3.002 Skipping dependency pipeline-model-definition:1.5.1 and its sub-dependencies, because there is a higher version defined on the top level - pipeline-model-definition:2.2151.ve32c9d209a_3f

dduportal added a commit to jenkins-infra/docker-jenkins-weekly that referenced this issue Jan 3, 2024
Ref. jenkins-infra/helpdesk#3880 (comment)

- This plugin has not been updated since 4 years (ref. https://plugins.jenkins.io/github-autostatus/dependencies/)
- It should be replaced by github-checks (https://plugins.jenkins.io/github-checks/)

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal
Copy link
Contributor

  • Deployed to both controllers with success
  • Checked (successfully) that cobertura, code-coverage-api and github-autostatus have been removed
  • Discarded the old data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants