chore: switch vagrant to Docker

[dduportal]

This PR is an attempt at moving away from virtualbox to docker as a provider to ensure an easier acceptance testing of the puppet provisioning.

The main target are macOS ARM CPUs for the first iteration, to allow team members with such a setup to be able to test their system.

Ping @smerle33 @timja if you are able to test this on your M1 machines:

# Checkout this PR locally
gh pr checkout 2235

# Bootstrap dependencies (requires `bundle` command installed and in your PATH)
./vagrant-bootstrap

# Install vagrant - https://www.vagrantup.com/downloads or "bundle install vagrant" if no option

# Try to start the pkg VM
vagrant up pkg

[timja]

I get this error:
rapid7/metasploit-framework#11368

Trying to run the suggested fix, (quite slow though)

[timja]

Next error is around installing r10k, nothing seems to install it and running gem install r10k doesn't add it to the path / I haven't found where it installs to

[dduportal]

Next error is around installing r10k, nothing seems to install it and running gem install r10k doesn't add it to the path / I haven't found where it installs to

Can you try prepending bundle exec on the r10k command? I remember cases where bundler maintains its own path

[timja]

tried to create Proc object without a block

I suspect it needs an old version of ruby? possible to update it?

[dduportal]

tried to create Proc object without a block

I suspect it needs an old version of ruby? possible to update it?

Gotta check, thanks for the feedback!

[dduportal]

@timja we juste tested on @smerle33 's M1 machine, with an installation from scratch (so with the macOS default ruby) and did not had these issues: I'll need help for reproduction (to provide the correct fix).

We succesfully tried (and pushed) the following:

• Fixed the r10k issue: since the Gemfile specifies r10k, we prepended the bundle exec to make sure it's not required to be installed before. On Stephan's machine, we had to cleanup r10k with sudo gem uninstall r10k before as he already had it installed and it was conflicting. I did not had any conflict (tested successfully) on my intel mac.
• Succesfully started the pkg "vagrant machine" (vagrant up pkg) which provisionned successully the role, with an amd64 Ubuntu 18.04 container on my machine and an arm64 Ubuntu 18.04 container on @smerle's machine.
• We had the jenkins::master vagrant machine failing when installing the Docker in Docker installation. I was able to fix this and test it successfully on my machine (vagrant up jenkins::master) but I was not able to validate on a M1 CPU though

[smerle33]

I can confirm that it's working perfectly : "vagrant up jenkins::master"

[timja]

I have a 3.x ruby not sure what the default one is.

[dduportal]

I have a 3.x ruby not sure what the default one is.

On my amd64 macOS 12.4, I got the following system ruby installation (which works) for reference:

$ which ruby && ruby --version
/usr/bin/ruby
ruby 2.6.8p205 (2021-07-07 revision 67951) [universal.x86_64-darwin21]

Let me try with a ruby 3.0 (using asdf). But it means that I should write the requirement in this PR.

[dduportal]

OK, README updated to mention the Ruby constraints (I've double checked my machine AND the Docker image).

Tested with success the vagrant up pkg and vagrant up jenkins::master on @smerle33 's M1 macOS + my AMD64 machine.

As it incrases the amount of environments where the vagrant stuff can be done, I'm setting this PR ready to review as it should be usable.

In order to improve this project and share knowledge, I've opened some issues:

• Bump Ruby dependency to 3.x (or at least 2.7) #2247
• Bring back automated acceptance testing for roles #2248
• Bring back the Acceptance Test Harness #2249
• Acceptance Tests: allow "Per VM" tests #2250

[dduportal]

Putting as draft until #2251 is merged + wip