Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump puppet module for apache to 7.0.0 + track its version with updatecli #2242

Merged

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jul 1, 2022

Blocked by #2263 and #2270

This PR bumps the Apache Puppet module to its latest stable version.

⚠️ It's a huge change (current 3.5.0 was release in Dec. 2018 while 7.0.0 in Oct. 2021).

Please do not merge it: it will be a team task that implies stopping puppet agent everywhere, then diffing before applying (see runbooks).

It introduces the following changes:

  • Bump module to latst stable (7.0.0)
  • Add an updatecli manifest to track this module version (and keep it up to date in the future)
  • As a consequence of the module upgrade (with deprecated attributes and behaviors changes in apache::vhosts resources):
    • Homogenize naming convention for apache::vhosts resources:
      • Resource Name: either it's named $fqdn for default TLS virtual host, or it's named $fqdn unsecure for HTTP virtual host
      • Log files: same: (suffix _unsecured for non tls access/error logs)
    • Specify servername attribute for ALL apache::vhosts resources
    • Specify use_servername_for_filenames and use_port_for_filenames attributes to avoid depreciation messages
    • Formatting puppet code with latest linter

@dduportal dduportal force-pushed the chore/bump-apache-puppet-module branch 3 times, most recently from b1aef52 to 6a0f451 Compare July 10, 2022 10:38
@dduportal dduportal force-pushed the chore/bump-apache-puppet-module branch from 6a0f451 to d6e6571 Compare July 12, 2022 08:40
@dduportal dduportal marked this pull request as ready for review July 12, 2022 08:41
@dduportal dduportal requested a review from a team as a code owner July 12, 2022 08:41
@dduportal dduportal marked this pull request as draft July 12, 2022 10:24
…h updatecli

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal force-pushed the chore/bump-apache-puppet-module branch from d6e6571 to 61eda07 Compare July 13, 2022 15:27
@dduportal dduportal marked this pull request as ready for review July 13, 2022 15:39
@dduportal dduportal marked this pull request as draft July 13, 2022 16:05
dduportal and others added 2 commits July 13, 2022 18:08
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dduportal dduportal marked this pull request as ready for review July 13, 2022 16:21
@dduportal dduportal merged commit d83cf20 into jenkins-infra:production Jul 13, 2022
@dduportal dduportal deleted the chore/bump-apache-puppet-module branch July 13, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants