fix(jenkins::controller) do not use ACP for maven repositories with id local
#2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d `in-project` nor `local`
dduportal
added a commit
to jenkins-infra/kubernetes-management
that referenced
this pull request
May 9, 2023
…id `in-project` nor `local` Related to jenkins-infra/helpdesk#3567 (comment) Twin of jenkins-infra/jenkins-infra#2821
|
Where does Can't we keep only one unique id for local/in project maven repository? |
I proposed Hence the 2 names excluded. |
|
Testing with jenkins-infra/helpdesk#3567 (comment) that it works as expected with the exception set up manually for Then let's use only |
dduportal
changed the title
in-project nor locallocal
lemeurherve
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#3567 (comment)
Needs a twin in jenkins-infra/kubernetes-management
This PR adds exlcusions from the ACP configurations file for any Maven repository which id would be
in-projectorlocalto allow loading JAR from source code local files.