-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The navigation bar layout is not preserved #6917
The navigation bar layout is not preserved #6917
Comments
Hi @sridamul! You should probably open an issue at https://github.com/jenkins-infra/jenkins-io-components and reference this. Our navbar component is currently located there. |
This is actually a known issue |
Hi @krisstern, Thanks for the clarification. I'll go ahead and close the issue now. Do you recommend opening a new issue at https://github.com/jenkins-infra/jenkins-io-components? |
Please do not close this issue but reference back to this for better tracking. |
Yes, I have already said so |
Okay! Grateful for your clarification. |
|
@Rekha-Ahir Could you please see if you could open a pull request to address this issue? I have a feeling this is not possible in the https://github.com/jenkins-infra/jenkins-io-components because multiple sites are already using the same navbar from this component except maybe the plugin site. And, I am not actually sure if we are planning to change the plugin site navbar at all. |
@krisstern i think you are right it will effect all the component but i will try to look out the issue by pull request |
@krisstern, just to clarify, the only difference is in the contribute spotlight nav bar. The plugin site and success stories maintain the same style (without a search bar), while the remaining tabs have consistent nav bar layouts (with a search bar). Therefore, I suggest focusing our attention solely on the contributor spotlight. What are your thoughts on this? |
Hi @sridamul I am not sure I am getting what you are saying 100%, we are just using the navbar component from @jenkinsci/jenkins-io-components as is currently: |
There is however some additional styling added for the plugin site navbar in https://github.com/jenkins-infra/plugin-site/blob/d87b02f35a0cc859a0e3a5619d6d0039e13e09d1/plugins/plugin-site/src/styles/base.css. |
Is there a same styling for the success stories too? |
If it is just a font size change needed for the navbar in contributor-spotlight I can take care of that. |
Yep, I think so |
Just submitted a PR to fix this, by setting a default fontsize in |
Suggestion
As I switch to 'Success Stories,' 'Contributor Spotlight,' and 'Plugins,' there is a variation in the navigation bar layout, while the others maintain the same navigation bar layout.
jenkins.Nav.Bar.Issue.mp4
It would be nice if the layout of the remaining three tabs could be preserved, excluding the search menu.
The text was updated successfully, but these errors were encountered: