Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct link to plugin removal #2485

Merged
merged 2 commits into from Sep 18, 2019
Merged

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Sep 16, 2019

Following jenkins-infra/update-center2#299 it might be easier to point directly to the file that needs editing.

CC @daniel-beck

@zbynek zbynek requested a review from a team as a code owner September 16, 2019 20:42
@jenkinsadmin
Copy link

Build failed; the context from the latest run is:

Expand to view
[2019-09-16T20:42:48.637Z] Pull request #2485 opened
[2019-09-16T20:42:48.639Z] Connecting to https://api.github.com using jenkinsadmin/****** (GitHub access token for jenkinsadmin)
[2019-09-16T20:42:49.477Z] Connecting to https://api.github.com to check permissions of obtain list of zbynek for jenkins-infra/jenkins.io
[2019-09-16T20:42:49.674Z] Loading trusted files from base branch master at 5680006a478a99639339ac6b0d2a2450709d8d9e rather than a141556bd87b38060f3c13ec5c6a4f10765f965d
[2019-09-16T20:57:35.326Z] 
[2019-09-16T20:57:35.326Z] GitHub has been notified of this commit’s build result
[2019-09-16T20:57:35.326Z] 
[2019-09-16T20:57:35.333Z] java.lang.OutOfMemoryError: Java heap space
[2019-09-16T20:57:35.333Z] Finished: FAILURE

Powered by the Comment Logger

@daniel-beck
Copy link
Contributor

Would rather link to the section in the readme to be more stable in case of changes.

I wonder whether it's possible to have stable anchors in Markdown so it would also resist a change of the section title.

@zbynek
Copy link
Contributor Author

zbynek commented Sep 17, 2019

@daniel-beck makes sense. The Readme is linked in the next sentence anyway, so maybe we can reduce it to just one link (see my last commit).

@daniel-beck daniel-beck merged commit 953342f into jenkins-infra:master Sep 18, 2019
@zbynek zbynek deleted the patch-4 branch August 7, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants