Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBSITE-206] Move guest post disclaimer to the front matter #2551

Merged
merged 3 commits into from Oct 12, 2019

Conversation

@zbynek
Copy link
Contributor

zbynek commented Oct 8, 2019

The goal of the ticket is to hide the initial NOTE from guest posts in the blog roll.

One way to do that would be to make the "summary" function smarter and detect parts of content that are not relevant. This PR proposes a simpler solution where the disclaimer is moved to the metadata and is only rendered in full view of the article, not in blog roll.

This approach requires changing the content of the articles, it's done for posts from the last two years.

@zbynek zbynek requested a review from jenkins-infra/copy-editors as a code owner Oct 8, 2019
@LinuxSuRen

This comment has been minimized.

Copy link
Member

LinuxSuRen commented Oct 9, 2019

A preview picture should be helpful.

@zbynek

This comment has been minimized.

Copy link
Contributor Author

zbynek commented Oct 9, 2019

After:
disclaimer-after
Before:
disclaimer-before
(The screenshots sugeest that the order of posts with the same date may not be deterministic, that's unrelated to this change).

Copy link
Contributor

oleg-nenashev left a comment

Looks fine, but we also need to update the contributing guidelines to reflect the new structure.

@oleg-nenashev

This comment has been minimized.

Copy link
Contributor

oleg-nenashev commented Oct 11, 2019

Maybe we should change "disclaimer" to "editor note" or so.. No strong opinion

@zbynek

This comment has been minimized.

Copy link
Contributor Author

zbynek commented Oct 11, 2019

Maybe we should change "disclaimer" to "editor note" or so.. No strong opinion

Whatever we decide won't affect readers, it's just a question of YML syntax for authors. So I think a single word would be preferable. Maybe just note? Or is it too generic? @MarkEWaite do you have any suggestions?

@oleg-nenashev

This comment has been minimized.

Copy link
Contributor

oleg-nenashev commented Oct 11, 2019

Copy link
Contributor

oleg-nenashev left a comment

LGTM, thanks!

@zbynek do you participate in Hacktoberfest just in case?

@zbynek

This comment has been minimized.

Copy link
Contributor Author

zbynek commented Oct 11, 2019

@oleg-nenashev yes, I do.

@oleg-nenashev oleg-nenashev merged commit 14a8cbb into jenkins-infra:master Oct 12, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.