[WEBSITE-206] Move guest post disclaimer to the front matter #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview picture should be helpful. |
|
After: |
oleg-nenashev
approved these changes
Oct 9, 2019
oleg-nenashev
approved these changes
Oct 11, 2019
|
Maybe we should change "disclaimer" to "editor note" or so.. No strong opinion |
Whatever we decide won't affect readers, it's just a question of YML syntax for authors. So I think a single word would be preferable. Maybe just |
|
+1 for just "note"
…On Fri, Oct 11, 2019, 19:16 Zbynek Konecny ***@***.***> wrote:
Maybe we should change "disclaimer" to "editor note" or so.. No strong
opinion
Whatever we decide won't affect readers, it's just a question of YML
syntax for authors. So I think a single word would be preferable. Maybe
just note? Or is it too generic? @MarkEWaite
<https://github.com/MarkEWaite> do you have any suggestions?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2551?email_source=notifications&email_token=AAW4RIDE5JQ43V7NLGSCWV3QOCYFHA5CNFSM4I6XJRCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBAUSWI#issuecomment-541149529>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RICOW3DQJSRY55ETUELQOCYFHANCNFSM4I6XJRCA>
.
|
oleg-nenashev
approved these changes
Oct 11, 2019
There was a problem hiding this comment.
LGTM, thanks!
@zbynek do you participate in Hacktoberfest just in case?
|
@oleg-nenashev yes, I do. |
LinuxSuRen
approved these changes
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of the ticket is to hide the initial NOTE from guest posts in the blog roll.
One way to do that would be to make the "summary" function smarter and detect parts of content that are not relevant. This PR proposes a simpler solution where the disclaimer is moved to the metadata and is only rendered in full view of the article, not in blog roll.
This approach requires changing the content of the articles, it's done for posts from the last two years.