New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JEP-14] - Public Jenkins Roadmap #2957
[JEP-14] - Public Jenkins Roadmap #2957
Conversation
@rtyler Co-authored-by: James Dumay <jdumay@cloudbees.com> Co-authored-by: R. Tyler Croy <rtyler@brokenco.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest refactoring the JS to follow some good practices. Something like:
(function () {
function createRoadmapCategory(...) {...}
function fetchRoadmap(...) {...}
// Better to use jQuery this way. using the $(function) is unreliable.
$(document).ready(function );
})()
@fqueiruga I am not a JavaScript expert, and TBH I do not know best JavaScript practices. If you are willing to submit a pull request against my branch, I will be happy to integrate the suggested changes |
I'll try to do it later today |
I know the old roadmap was done this way: and I don't want to discourage @fqueiruga from writing nicer JS for this, but why is it JS in the first place? Couldn't we build the page using |
Wrap the roadmap JS within a IIFE
…into jenkins-roadmap-2020
I updated the layout to use HAML instead of Javascript, YAML is now also used as a data storage. Feedback is welcome! P.S: I know that the UI looks worse now, to be improved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
Could we consider using the background color from the "Future" for the "Current" cells so that the higher contrast background is on the current projects? I find it much more difficult to read the "Current" column than the "Future" column because of the lower contrast difference between "Current" text and "Current" background. The background color behind the "Future" column makes the text very easy for me to read. |
I am not sure colors add much benefits at all. Maybe we could reserve them for a second-level categorization instead of highlighting statuses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent and awesome @oleg-nenashev. Thank you for this
I agree with you, but I suggest to do it in a follow-up pull request. This roadmap is not final anyway, but I would like to get something posted to work on that incrementally |
See the JEP for motivation and specification: https://github.com/jenkinsci/jep/tree/master/jep/14
Current draft: