Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JEP-14] - Public Jenkins Roadmap #2957

Merged
merged 14 commits into from Apr 1, 2020

Conversation

oleg-nenashev
Copy link
Contributor

@oleg-nenashev oleg-nenashev commented Mar 12, 2020

See the JEP for motivation and specification: https://github.com/jenkinsci/jep/tree/master/jep/14

Current draft:
image

oleg-nenashev and others added 2 commits March 12, 2020 13:18
@rtyler

Co-authored-by: James Dumay <jdumay@cloudbees.com>
Co-authored-by: R. Tyler Croy <rtyler@brokenco.de>
Copy link
Contributor

@fqueiruga fqueiruga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest refactoring the JS to follow some good practices. Something like:

(function () {
    function createRoadmapCategory(...) {...}
    function fetchRoadmap(...) {...}

    // Better to use jQuery this way. using the $(function) is unreliable.
    $(document).ready(function );
})()

@oleg-nenashev
Copy link
Contributor Author

@fqueiruga I am not a JavaScript expert, and TBH I do not know best JavaScript practices. If you are willing to submit a pull request against my branch, I will be happy to integrate the suggested changes

@fqueiruga
Copy link
Contributor

I'll try to do it later today

@zbynek
Copy link
Contributor

zbynek commented Mar 19, 2020

I know the old roadmap was done this way:
7267dd2#diff-4d70295e9d7e65e3fac755da4e92f23c

and I don't want to discourage @fqueiruga from writing nicer JS for this, but why is it JS in the first place? Couldn't we build the page using haml at build time? It would be definitely better for SEO. / page loading speed.

@oleg-nenashev oleg-nenashev changed the title [JEP-TODO] - Public Jenkins Roadmap [JEP-14] - Public Jenkins Roadmap Apr 1, 2020
@oleg-nenashev oleg-nenashev marked this pull request as ready for review April 1, 2020 13:29
@oleg-nenashev oleg-nenashev requested a review from a team as a code owner April 1, 2020 13:29
@oleg-nenashev
Copy link
Contributor Author

I updated the layout to use HAML instead of Javascript, YAML is now also used as a data storage. Feedback is welcome!

P.S: I know that the UI looks worse now, to be improved

Copy link
Contributor

@tracymiranda tracymiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@MarkEWaite
Copy link
Contributor

Could we consider using the background color from the "Future" for the "Current" cells so that the higher contrast background is on the current projects? I find it much more difficult to read the "Current" column than the "Future" column because of the lower contrast difference between "Current" text and "Current" background.

The background color behind the "Future" column makes the text very easy for me to read.

@oleg-nenashev
Copy link
Contributor Author

I am not sure colors add much benefits at all. Maybe we could reserve them for a second-level categorization instead of highlighting statuses

Copy link
Contributor

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent and awesome @oleg-nenashev. Thank you for this

@oleg-nenashev
Copy link
Contributor Author

@MarkEWaite

Could we consider using the background color from the "Future" for the "Current" cells so that the higher contrast background is on the current projects? I find it much more difficult to read the "Current" column than the "Future" column because of the lower contrast difference between "Current" text and "Current" background. The background color behind the "Future" column makes the text very easy for me to read.

I agree with you, but I suggest to do it in a follow-up pull request. This roadmap is not final anyway, but I would like to get something posted to work on that incrementally

@MarkEWaite MarkEWaite merged commit 889bf66 into jenkins-infra:master Apr 1, 2020
@oleg-nenashev oleg-nenashev deleted the jenkins-roadmap-2020 branch April 1, 2020 17:27
@oleg-nenashev oleg-nenashev added the roadmap The change is related to the public roadmap. https://jenkins.io/project/roadmap/ label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
governance roadmap The change is related to the public roadmap. https://jenkins.io/project/roadmap/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants