Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to official docker jenkins/jenkins image #3852

Merged
merged 16 commits into from
Oct 31, 2020

Conversation

vsilverman
Copy link
Member

This PR continues updates, started by PR #3843 .
Now besides Tutorials Build Tools updates cover Installing Jenkins and Pipeline chapters of Jenkins Handbook and supports Blueocean chapter.

Current PR is an attempt to fix such issues as #3315, #3583, #3650, and others, related to using new official Jenkins docker image.

@vsilverman vsilverman requested a review from a team as a code owner October 6, 2020 23:41
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like a review from @jvz to assess the alternatives. He made the most recent improvement and found a way for us to use the Docker in Docker image with Blue Ocean.

A few items that need to be corrected. Unfortunately, I don't know how to have command line access to the docker socket through the Docker CE cli without running as the root user. I assume it will require that the user inside the Docker container must have Docker permissions ?

content/doc/book/installing/_docker.adoc Outdated Show resolved Hide resolved
content/doc/book/installing/_docker.adoc Outdated Show resolved Hide resolved
content/doc/book/installing/_docker.adoc Outdated Show resolved Hide resolved
content/doc/book/installing/_docker.adoc Outdated Show resolved Hide resolved
vsilverman and others added 6 commits October 16, 2020 09:06
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
…nkins.io into switch-to-official-dkr-img

Merging from origin
@jvz
Copy link
Contributor

jvz commented Oct 20, 2020

That looks right so far.

Copy link
Member Author

@vsilverman vsilverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor syntax changes

@vsilverman
Copy link
Member Author

  • synced with the latest master branch
  • updated version of docker Jenkins official LTS release

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsilverman I ran interactive tests and made changes that I've pushed as proposed changes

@MarkEWaite MarkEWaite merged commit f8675e2 into jenkins-infra:master Oct 31, 2020
@jvz
Copy link
Contributor

jvz commented Oct 31, 2020

I forgot to leave a final review, but these updates look great!

@MarkEWaite
Copy link
Contributor

Thanks @jvz . I'm preparing a pull request that will correct some mistakes that I detected and will update the tutorials to use the same technique. Special thanks to @vsilverman for finding a path forward.

@MarkEWaite
Copy link
Contributor

See #3919 for the next step in the evolution of the tutorials and the installation guide. Still need to find a way to deduplicate the content that is the same in _docker.adoc and _docker-for-tutorials.adoc. Some form of setting one or more variables in the tutorial header to provide the extra content. That will be for a future pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants