-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to official docker jenkins/jenkins image #3852
Switching to official docker jenkins/jenkins image #3852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like a review from @jvz to assess the alternatives. He made the most recent improvement and found a way for us to use the Docker in Docker image with Blue Ocean.
A few items that need to be corrected. Unfortunately, I don't know how to have command line access to the docker socket through the Docker CE cli without running as the root user. I assume it will require that the user inside the Docker container must have Docker permissions ?
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
…nkins.io into switch-to-official-dkr-img Merging from origin
That looks right so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor syntax changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vsilverman I ran interactive tests and made changes that I've pushed as proposed changes
I forgot to leave a final review, but these updates look great! |
Thanks @jvz . I'm preparing a pull request that will correct some mistakes that I detected and will update the tutorials to use the same technique. Special thanks to @vsilverman for finding a path forward. |
See #3919 for the next step in the evolution of the tutorials and the installation guide. Still need to find a way to deduplicate the content that is the same in _docker.adoc and _docker-for-tutorials.adoc. Some form of setting one or more variables in the tutorial header to provide the extra content. That will be for a future pull request. |
This PR continues updates, started by PR #3843 .
Now besides Tutorials Build Tools updates cover Installing Jenkins and Pipeline chapters of Jenkins Handbook and supports Blueocean chapter.
Current PR is an attempt to fix such issues as #3315, #3583, #3650, and others, related to using new official Jenkins docker image.