updated Jenkins on AWS tutorial documentation #5629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paulmarsicloud
commented
Oct 26, 2022
paulmarsicloud
commented
- Updated the older AWS Console UI images to the newer version
- Added step by step instructions for Configure Clouds as well
probot-autolabeler
bot
added
the
documentation
dduportal
approved these changes
Oct 26, 2022
content/doc/tutorials/tutorial-for-installing-jenkins-on-AWS.adoc
Outdated
Show resolved
Hide resolved
kmartens27
reviewed
Oct 26, 2022
There was a problem hiding this comment.
Hi @paulmarsicloud, thanks so much for your work on this tutorial! I made a few small suggestions on some formatting/syntax instances, but outside of that this looks great!
Let me know if you have any questions or feedback!
content/doc/tutorials/tutorial-for-installing-jenkins-on-AWS.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/tutorial-for-installing-jenkins-on-AWS.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/tutorial-for-installing-jenkins-on-AWS.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/tutorial-for-installing-jenkins-on-AWS.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/tutorial-for-installing-jenkins-on-AWS.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/tutorial-for-installing-jenkins-on-AWS.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/tutorial-for-installing-jenkins-on-AWS.adoc
Outdated
Show resolved
Hide resolved
|
Thank you @dduportal and @kmartens27 for the awesome feedback! I've gone ahead and applied those changes and re-pushed 👍 |
dduportal
approved these changes
Oct 27, 2022
lemeurherve
approved these changes
Oct 27, 2022
content/doc/tutorials/tutorial-for-installing-jenkins-on-AWS.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/tutorial-for-installing-jenkins-on-AWS.adoc
Outdated
Show resolved
Hide resolved
content/doc/tutorials/tutorial-for-installing-jenkins-on-AWS.adoc
Outdated
Show resolved
Hide resolved
|
Thanks for the feedback @lemeurherve - changes added 👍 |
lemeurherve
approved these changes
Oct 28, 2022
kmartens27
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Thanks for your work on this @paulmarsicloud, this is fantastic! We appreciate the contributions to help improve Jenkins!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.