Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated changelog for 2.397 #6171

Merged
merged 4 commits into from Mar 28, 2023
Merged

Conversation

jenkins-infra-changelog-generator[bot]
Copy link
Contributor

@probot-autolabeler probot-autolabeler bot added the changelog Jenkins changelogs label Mar 21, 2023
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 21, 2023
@github-actions
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 22, 2023
@jenkins-infra-changelog-generator jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.397 branch 3 times, most recently from 3de4372 to 0c51d7b Compare March 24, 2023 08:49
@jenkins-infra-changelog-generator jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.397 branch 4 times, most recently from 524f54b to a66c352 Compare March 28, 2023 08:38
@MarkEWaite MarkEWaite enabled auto-merge (squash) March 28, 2023 13:38
Copy link
Contributor

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MarkEWaite!

@MarkEWaite
Copy link
Contributor

@kmartens27 could you submit an issue report to the automatic changelog generator to report that the localization label on Jenkins core pull requests is being ignored when generating the changelog? It may be intentional or it may be specific to the format of the GitHub pull request descriptions in those two pull requests, but it was a surprise for me to see that the GitHub release included two localization items that were not included in the generated changelog either as entries or as comments.

The pull requests in core that were not included by the changelog generator were:

@kmartens27
Copy link
Contributor

@MarkEWaite, sure thing, I can definitely take care of submitting that

title: Spring framework BOM 5.3.26 release notes
- pull: 7760
message: |-
Bump spring-framework-bom from 5.3.25 to 5.3.26.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spring-framework-bom is not an English word, so it should either be placed in backticks or replaced with a valid English sentence. One example of a valid English sentence would be:

Upgrade Spring Framework from 5.3.25 to 5.3.26.

CC @kmartens27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Jenkins changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants