Jenkins.io - Updating Docker installation guide #6512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
documentation
LizGaudet
approved these changes
Jul 5, 2023
MarkEWaite
approved these changes
Jul 6, 2023
| @@ -52,15 +52,15 @@ Due to the use of a privileged container, this is recommended, though it require | |||
| This environment variable controls the root directory where Docker TLS certificates are managed. | |||
| <8> Maps the `/certs/client` directory inside the container to a Docker volume named `jenkins-docker-certs` as created above. | |||
| <9> Maps the `/var/jenkins_home` directory inside the container to the Docker volume named `jenkins-data`. | |||
| This will allow for other Docker containers controlled by this Docker container's Docker daemon to mount data from Jenkins. | |||
| This allows for other Docker containers controlled by this Docker container's Docker daemon to mount data from Jenkins. | |||
There was a problem hiding this comment.
Phrasing seems odd to me with the "for" in the phrase. However, my English grammar is weak, so I am perfectly fine if you correct me and tell me that it is more correct to say "allow for other" than to say "allows other". Optional.
Suggested change
| This allows for other Docker containers controlled by this Docker container's Docker daemon to mount data from Jenkins. | |
| This allows other Docker containers controlled by this Docker container's Docker daemon to mount data from Jenkins. |
There was a problem hiding this comment.
My English grammar is super poor, but I've got a few tools to help.
One of them got rid of the for. 🤷
Would have preferred to use the symbolic version {jenkins-stable} but it
is not replaced with the actual version when I run the site build
locally. Better to have a short term reference to jdk17 without the
precise version than to continue using the jdk11 version.
MarkEWaite
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documentation is being updated as a part of the Java 17 transition.
The Docker installation guide does not contain any specific Java version text, but I have gone through to update some of the syntax and the page formatting. Previously, the text was composed with a line limit for text, but has been updated to be more in line with Asciidoc best practices.
This is for the Docker installation and Docker installation instruction pages. The later is an include file that is part of the overall docker.adoc page.
Most of the existing text was left as is, so there is room for further improvement/updates