Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins.io - updating "Using Agents" for Java 17 #6527

Merged
merged 2 commits into from Jul 11, 2023

Conversation

kmartens27
Copy link
Contributor

This PR is to update the usage of Java 11 on the "Using Agents" documentation.

In the Windows code example pt 1, it is using jenkins/ssh-agent:jdk11, so it has been updated to jenkins/ssh-agent:jdk17.

This is the only updated needed in the page from what I have reviewed.

@kmartens27 kmartens27 requested a review from a team as a code owner July 11, 2023 18:01
@probot-autolabeler probot-autolabeler bot added the documentation Jenkins documentation, including user and developer docs, solution pages, etc. label Jul 11, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file also needs an update in the Linux instructions to use an Alpine container image that is running Java 17. https://hub.docker.com/u/jenkins includes the container images and the available tags are listed there.

@kmartens27
Copy link
Contributor Author

Thank you @MarkEWaite, I've gone and added the alpine-jdk17 version to the code example for Linux instructions.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit 7ccf036 into jenkins-infra:master Jul 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Jenkins documentation, including user and developer docs, solution pages, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants