Jenkins.io - Update "Build a Java app with Maven" for Java 17 #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
documentation
LizGaudet
approved these changes
Jul 19, 2023
| restart Jenkins, simply follow the restart instructions in | ||
| <<stopping-and-restarting-jenkins,Stopping and restarting Jenkins>> and then | ||
| proceed on. | ||
| This tutorial shows you how to use Jenkins to orchestrate building a simple Java application with https://maven.apache.org/[Maven]. |
There was a problem hiding this comment.
Suggested change
| This tutorial shows you how to use Jenkins to orchestrate building a simple Java application with https://maven.apache.org/[Maven]. | |
| This tutorial shows you how to use Jenkins to build a simple Java application with https://maven.apache.org/[Maven]. |
| The simple Java application, which you'll obtain from a sample repository on GitHub, outputs the string "Hello world!" and is accompanied by a couple of unit tests to check that the main application works as expected. | ||
| The results of these tests are saved to a JUnit XML report. | ||
|
|
||
| *Duration:* This tutorial takes 20-40 minutes to complete (assuming you've already met the <<prerequisites,prerequisites>> below). |
There was a problem hiding this comment.
Suggested change
| *Duration:* This tutorial takes 20-40 minutes to complete (assuming you've already met the <<prerequisites,prerequisites>> below). | |
| *Duration:* This tutorial takes 20-40 minutes to complete, assuming you meet the below <<prerequisites,prerequisites>>. |
There was a problem hiding this comment.
I looked at https://docs.cloudbees.com/docs/beewrite/latest/syntax/links#_link_to_a_section_on_the_same_page and https://docs.asciidoctor.org/asciidoc/latest/macros/xref/#explicit-link-text, but you just may want to make sure your inline links are correct throughout this file.
MarkEWaite
requested changes
Jul 24, 2023
MarkEWaite
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Java 17 transition project, I have updated the Java/Maven tutorial to use 'maven:3.9.3-eclipse-temurin-17'.
I have also gone through and updated some of the wording/syntax and formatting of the document overall. There were several updates made for inclusive naming and accessibility purposes too. The formatting was a big part, and most of the changes had to do with this.
I tried my best to keep the instructions the same while improving the syntax, but there may be some instances where the change is not an improvement.