Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): Separate LTS and BOM versions updatecli manifests #6780

Merged
merged 9 commits into from Nov 17, 2023

Conversation

gounthar
Copy link
Contributor

Up to now, we have been using one manifest to update the Jenkins LTS versions in various parts of the documentation simultaneously with the BOM versions.
In some cases, the title was quite clear, such as:

Bump Jenkins LTS versions to 2.414.2 in various parts of the documentation

and accurately reflected the update to this version. However...
In other instances, the title was:

Bump Jenkins LTS versions to 2.414.3 in various parts of the documentation

and it created confusion as we were only updating the BOM version... This issue was highlighted here.

Therefore, I propose having two separate manifests, leading to two distinct PRs (which may or may not occur simultaneously): one for the Jenkins LTS versions and another for the plugin bill of materials versions.

The PR titles would be such as:

  • Update the plugin bill of materials versions to 2507.vcb_18c56b_f57c in various parts of the documentation
  • Update Jenkins LTS versions to 2.414.3 in various parts of the documentation

Please have a look at two generated PRs on my fork:

@gounthar gounthar marked this pull request as draft October 19, 2023 17:24
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Please take a moment and address the merge conflicts of your pull request. Thanks!

Copy link
Contributor

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the work on this @gounthar !

@dduportal
Copy link
Contributor

nitpick on the title: this must be a chore as merging this PR does not add anything the "artifact produced and consumed by the repository" (e.g. jenkins.io website), but it adds something to a transversal subsystem not consumed directly by end-users

@gounthar gounthar changed the title feat(dependencies): Separate LTS and BOM versions updatecli manifests chore(dependencies): Separate LTS and BOM versions updatecli manifests Nov 17, 2023
@kmartens27 kmartens27 merged commit d12cc61 into jenkins-infra:master Nov 17, 2023
9 checks passed
@gounthar gounthar deleted the lts-and-bom branch November 17, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants